Skip to content

fix(i18n): translate remaining zh DNS strings + remove dead MediaCard#93

Merged
lyfuci merged 1 commit into
mainfrom
fix/i18n-dns-and-deadcode
Jun 7, 2026
Merged

fix(i18n): translate remaining zh DNS strings + remove dead MediaCard#93
lyfuci merged 1 commit into
mainfrom
fix/i18n-dns-and-deadcode

Conversation

@lyfuci

@lyfuci lyfuci commented Jun 7, 2026

Copy link
Copy Markdown
Owner

What

Two fixes from an automated audit of the codebase:

  1. HIGH — Chinese DNS tool showed English text. pages.dns.status / answers / noAnswers / noDirect were never translated in zh-CN.json, so Chinese users saw "Status", "{{n}} answers", "no answers", "No direct answer; authority: …". Now translated (状态 / {{n}} 条记录 / 无记录 / 无直接答案;授权服务器:{{authority}}).
  2. Dead code — deleted src/components/media/MediaCard.tsx, the single-file card from the pre-timeline media tool; it has had zero imports since the timeline rewrite (feat(media): 剪映-style multi-track timeline video editor #91).

Note: src/lib/media-ops.ts was flagged by the audit as dead too, but it's kept — it backs the Quick-tools dialog added in #92 (the audit ran before #92 merged).

Verification

  • pnpm typecheck / pnpm lint / pnpm build clean; 388 tests green.
  • zh/en DNS parity check now reports no untranslated strings.

🤖 Generated with Claude Code

…MediaCard

- src/i18n/zh-CN.json: pages.dns.status / answers / noAnswers / noDirect were
  left in English, so the Chinese DNS tool showed English labels/messages.
  Translated all four (状态 / {{n}} 条记录 / 无记录 / 无直接答案;授权服务器:…).
- src/components/media/MediaCard.tsx: deleted. It was the single-file card from
  the pre-timeline media tool and has had zero imports since the timeline
  rewrite (#91).

Verified: typecheck / lint / build clean; 388 tests green; DNS zh parity check
now reports no untranslated strings. (media-ops.ts is intentionally kept — it
backs the Quick-tools dialog from #92.)

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
@lyfuci lyfuci merged commit c55e32c into main Jun 7, 2026
2 checks passed
@lyfuci lyfuci deleted the fix/i18n-dns-and-deadcode branch June 7, 2026 16:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant