Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update site probabilities for PRG trial #115

Merged
merged 2 commits into from
Feb 13, 2023

Conversation

stephen-soltesz
Copy link
Contributor

@stephen-soltesz stephen-soltesz commented Feb 13, 2023

This change adjusts the site probabilities of PRG and regional cloud sites to direct more traffic to regional locations outside of PRG.

This change additionally restores the --no-promote flag for production deployments due to #114

Part of:


This change is Reviewable

@coveralls
Copy link
Collaborator

Pull Request Test Coverage Report for Build 799

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 96.333%

Totals Coverage Status
Change from base Build 796: 0.0%
Covered Lines: 1576
Relevant Lines: 1636

💛 - Coveralls

@stephen-soltesz stephen-soltesz changed the title Sandbox soltesz update prg Update site probabilities for PRG trial Feb 13, 2023
Copy link
Contributor

@nkinkade nkinkade left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:, with one small question.

Reviewed 2 of 2 files at r1, all commit messages.
Reviewable status: :shipit: complete! 1 of 1 approvals obtained (waiting on @stephen-soltesz)


cloudbuild/cloudbuild.yaml line 51 at r1 (raw file):

    -e 's/{{REDIS_ADDRESS}}/$_REDIS_ADDRESS/'
    app.yaml
  - gcloud --project $PROJECT_ID app deploy --no-promote app.yaml

Just checking that this should in fact be --no-promote

Copy link
Contributor Author

@stephen-soltesz stephen-soltesz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewable status: :shipit: complete! 1 of 1 approvals obtained (waiting on @nkinkade)


cloudbuild/cloudbuild.yaml line 51 at r1 (raw file):

Previously, nkinkade wrote…

Just checking that this should in fact be --no-promote

Yes, without --no-promote the deployment disrupts continuity of service - see the image in #114

With this change we will have to manually promote the new version gradually, but we should be able to create a tool to do this for us shortly.

@stephen-soltesz stephen-soltesz merged commit f5db798 into main Feb 13, 2023
@stephen-soltesz stephen-soltesz deleted the sandbox-soltesz-update-prg branch February 13, 2023 18:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants