Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add a basic HTML page for the default endpoint in ndt7-prometheus-exporter #84

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Add a basic HTML page for the default endpoint in ndt7-prometheus-exporter #84

wants to merge 2 commits into from

Conversation

fhltang
Copy link
Contributor

@fhltang fhltang commented Sep 25, 2022 •
edited by robertodauria
Loading

This is a small follow up to PR #77 .

This change is Reviewable

@coveralls
Copy link

Pull Request Test Coverage Report for Build 193

  • 35 of 98 (35.71%) changed or added relevant lines in 2 files are covered.
  • 2 unchanged lines in 1 file lost coverage.
  • Overall coverage decreased (-16.0%) to 73.301%
Changes Missing Coverage Covered Lines Changed/Added Lines %
cmd/ndt7-prometheus-exporter/main.go 0 5 0.0%
cmd/ndt7-prometheus-exporter/web.go 35 93 37.63%
Files with Coverage Reduction New Missed Lines %
internal/upload/upload.go 2 96.4%
Totals Coverage Status
Change from base Build 192: -16.0%
Covered Lines: 766
Relevant Lines: 1045
💛 - Coveralls

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@fhltang @coveralls