Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added counter-query parameter #33

Open
wants to merge 37 commits into
base: main
Choose a base branch
from
Open

added counter-query parameter #33

wants to merge 37 commits into from

Conversation

lcorsini
Copy link

@lcorsini lcorsini commented Mar 11, 2021

This is a quick change to add support for counter metrics, I don't know if this is something other needs but was a requirement in our projects
after some months of testing I tought it would be good to make a pr :D


This change is Reviewable

@coveralls
Copy link
Collaborator

coveralls commented Mar 11, 2021

Pull Request Test Coverage Report for Build 142

  • 31 of 79 (39.24%) changed or added relevant lines in 2 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-18.3%) to 81.679%

Changes Missing Coverage Covered Lines Changed/Added Lines %
internal/setup/setup.go 0 8 0.0%
internal/config/config.go 31 71 43.66%
Totals Coverage Status
Change from base Build 139: -18.3%
Covered Lines: 214
Relevant Lines: 262

💛 - Coveralls

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants