Skip to content

Conversation

@surbhigoel77
Copy link
Collaborator

@surbhigoel77 surbhigoel77 commented Jul 28, 2025

Fixes #49 #50

@surbhigoel77 surbhigoel77 marked this pull request as draft July 28, 2025 14:22
@surbhigoel77 surbhigoel77 self-assigned this Jul 28, 2025
@surbhigoel77 surbhigoel77 added the documentation Improvements or additions to documentation label Jul 28, 2025
@surbhigoel77 surbhigoel77 marked this pull request as ready for review July 29, 2025 09:48
@surbhigoel77 surbhigoel77 requested a review from ma595 July 29, 2025 09:49
@ma595 ma595 changed the title Updating README structure Update README structure Jul 30, 2025
</p>

Spinup-Evaluation was developed to assess the DINO configuration of NEMO, but new metrics can be added to metrics.py to make it compatible with any ocean model. See [Adding New Metrics](#adding-new-metrics) for details.
## Using Spinup Evaluation
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you keep this named Usage? Also, even though the text is valid, perhaps we should keep the README as brief and succinct as possible - the RTD will contain more helpful info to use the tool, much like weatherbench2.

Copy link
Member

@ma595 ma595 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @surbhigoel77, this is coming together nicely. A few suggestions as discussed yesterday:

  • Update the README in line with tag v0.0.1. I.e. the API. #46
  • Check spelling in places.
  • Keep the README quite short - it's an entrypoint to the tool, RTD will contain more information (i.e. on how to add new metrics). We can reference this in the README, but no more. See Weatherbench2.
  • Remove the tree repo structure.
  • Quick mention of running tests (when they exist).
  • Separately we need to start a Contributing.md
  • I was going to suggest merging in the diagram from #31, but I don't think it's valid anymore. We need to think about how to demonstrate the tool pictorially. Suggestions welcome.

## Command line scripts

## Installation
### Installing Spinup Evaluation
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As previous, keep this named Installation and keep at the same level as before. This should appear before Usage .

# Configure pre-commit hooks
pre-commit install
```
### Running on Saved Restart File
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The use of the code has now changed regarding #46

--output <path-to-output>
```

### Running on Predictions [TODO]
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The use of the code has now changed regarding #46. Also, we don't run on predictions anymore.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

well, we do, but these are as the restart files.

<!-- > ![alt text](image.png) -->


## Adding New Metrics
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd avoid putting this in the README. Better to have it in the RTD.

@surbhigoel77 surbhigoel77 marked this pull request as draft August 11, 2025 16:50
@surbhigoel77
Copy link
Collaborator Author

surbhigoel77 commented Aug 11, 2025

Self note for @surbhigoel77:

  1. The refactored comparison code reads the reference data (simulations) from one separate folder (e.g. DINO_EXP00_ref) and predicted data from another folder (e.g. DINO_EXP00).
  2. The code runs on 3 modes - output, restart, both and results get stored in separate csv files
  3. There are two more files as functionality of main.py is split into separate files - cli.py and metrics_io.py

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

documentation Improvements or additions to documentation

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[META] Documentation

3 participants