Move to standard and up-to-date prom client_golang libs #3220
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
sconover
force-pushed
the
sconover/standard-prom-client-libs
branch
from
982dd86 to
a4f809d
Compare
sconover
commented
Feb 13, 2021
| @@ -150,3 +148,5 @@ replace go.etcd.io/bbolt => go.etcd.io/bbolt v1.3.5 | |||
|
|
|||
| // https://github.com/ory/dockertest/issues/212 | |||
| replace golang.org/x/sys => golang.org/x/sys v0.0.0-20200826173525-f9321e4c35a6 | |||
|
|
|||
| replace github.com/uber-go/tally => github.com/chronosphereio/tally v1.1.1-0.20210212113941-8eb2df32840b | |||
There was a problem hiding this comment.
This is a draft PR in part because there's also a PR in progress for the tally update here.
- Use chronosphere tally, which does a similar migration - Migrate prom client_golang-related code in m3 - Remove references to the m3db prom libs
sconover
force-pushed
the
sconover/standard-prom-client-libs
branch
from
a4f809d to
6c525a9
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #3220 +/- ##
=========================================
- Coverage 72.3% 72.3% -0.1%
=========================================
Files 1094 1094
Lines 101123 101123
=========================================
- Hits 73207 73190 -17
- Misses 22860 22869 +9
- Partials 5056 5064 +8
Flags with carried forward coverage won't be shown. Click here to find out more. Continue to review full report in Codecov by Sentry.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See proposal #18
What this PR does / why we need it:
M3 depends on mid-2018 forks of the various prometheus/client_golang -related projects (which appear to have no modifications). The principle reason is to make it so M3, and projects dependent on M3, are able to stay near
"latest-stable" of this important library, for all the normal reasons that's desirable.