Design pipeline: UX overhaul across all app pages#24
Merged
Conversation
Full design critique and remediation pass across dashboard, analytics, compare, search, obligations, deals, document detail, and graph pages. Bug fixes: - Fix search highlightMatch regex stateful lastIndex bug - Fix mobile nav active state mismatch (startsWith vs exact match) - Add click-outside handlers for compare picker and export dropdown - Change modal backdrops to onMouseDown for touch device reliability - Fix document.addEventListener shadowing with window.document Empty states (delight): - Analytics: skeleton preview of stat cards + heatmap grid - Compare: side-by-side document skeleton preview - Deals: 3-column capability grid with guided CTA - Obligations: filtered vs unfiltered states with clear-filters action - Search: shows failed query, mode, and mode-switching buttons - Graph: dynamic empty state with document filename Visual improvements: - Risk level border-l-4 accents on analytics stat cards and clause cards - Graph page: pinch-to-zoom, touch pan, mobile filter chips, bottom sheet - Varied motion choreography per page (scale, x-slide, opacity-only) - Page headers render instantly (no animation delay) - Standardized h1 sizing, empty state padding, main content padding - Obligations view button: title -> aria-label Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
- Add 21 new tests covering all PR checklist items (instant headers, search highlight, mobile nav, compare picker, modal dismiss, empty states, risk borders, h1 sizing, motion variation) - Fix all test files to use port 3001 matching playwright.config.ts - Update empty state text assertions to match redesigned content - Fix obligations selector (title -> aria-label) All 84 chromium + 68 mobile-chrome tests passing. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Full design critique and remediation pass across all 7 app pages (dashboard, analytics, compare, search, obligations, deals, document detail + graph). This PR addresses every issue flagged by the critique audit.
9 files changed, 563 insertions, 134 deletions
Bug Fixes
highlightMatchregex statefullastIndexbug causing alternating match failuresstartsWith, mobile used exact match)onMouseDownfor touch device reliability (deals, BYOK, report)documentvariable shadowing fix (window.documentfor DOM access)Empty States (Delight)
Visual Improvements
border-l-4accents on analytics stat cards, risk items, and clause cardsy:20)text-3xl), empty state padding (p-10 sm:p-14), main content paddingTest plan
next buildcompiles successfully)/documents/123)🤖 Generated with Claude Code