feat: Remove the existing code and added new method 'getUserAudience' #542
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Mansi-mParticle
changed the title
Mansi-mParticle
force-pushed
the
feat/6131-audience-api-android-cherry-pick
branch
from
a4374af to
89242e9
Compare
rmi22186
requested changes
Feb 15, 2025
android-core/src/main/java/com/mparticle/identity/MParticleIdentityClientImpl.java
Outdated
Show resolved
Hide resolved
android-core/src/main/java/com/mparticle/internal/ConfigManager.java
Outdated
Show resolved
Hide resolved
android-core/src/main/java/com/mparticle/internal/MParticleApiClientImpl.java
Outdated
Show resolved
Hide resolved
Comment on lines
105
to
+107
| protected MPUrl getUrl(Endpoint endpoint, @Nullable String identityPath) throws MalformedURLException { | ||
| return getUrl(endpoint, identityPath, false); | ||
| return getUrl(endpoint, identityPath, false,null); | ||
| } |
There was a problem hiding this comment.
This looks like it's new relative to the previous PR's getUrl changes here
can you clarify why? if my memory serves, i recall you discussing refactoring this after it being a pretty confusing section of the code for getting the URL , right?
There was a problem hiding this comment.
This method is specifically for the Identity API. In this case, Audience parameter should be set to null.
|
take a look at these as well - Is there anything major? |
rmi22186
reviewed
Feb 20, 2025
android-core/src/main/java/com/mparticle/networking/MParticleBaseClientImpl.java
Outdated
Show resolved
Hide resolved
android-core/src/main/java/com/mparticle/internal/MParticleApiClientImpl.java
Outdated
Show resolved
Hide resolved
android-core/src/main/java/com/mparticle/identity/MParticleIdentityClientImpl.java
Outdated
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Instructions
developmentSummary
Testing Plan
Reference Issue (For mParticle employees only. Ignore if you are an outside contributor)