ci: Update carthage.sh for Xcode 15 and ARM Macs #253
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
einsteinx2
deleted the
ci/6168-update-carthage-sh-xcode15-and-arm-macs
branch
einsteinx2
added a commit
that referenced
this pull request
Feb 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Our carthage.sh script used by the SDK release action did not support Xcode 15 as it requires new environment variables. Also it didn't support ARM build hosts which also need their own environment variables to get regular framework builds to use x86_64 architecture instead of arm64 like a device. This change adds the correct variables to fix both of those issues, allowing us to up our CI builds to use Xcode 15 and support the new ARM Mac Github runners that are starting to roll out.
Testing Plan
Reference Issue (For mParticle employees only. Ignore if you are an outside contributor)