Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump Android SDK Version #122

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

brito-rbi
Copy link

@brito-rbi brito-rbi commented Apr 17, 2023

Summary

Bump mParticle Android SDK version.

Testing Plan

Master Issue

Closes https://go.mparticle.com/work/REPLACEME

@brito-rbi
Copy link
Author

@BrandonStalnaker, can we get workflow approval here? We need to get moving on a version bump as our apps will be removed from the Android store without the version bump

Copy link
Member

@samdozor samdozor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good but it also should be unnecessary. This line says "use any version later than 5.9.3". So you can put any version that you want directly in your build (and we'd recommend you do so to be intentional about your SDK version).

@samdozor
Copy link
Member

@brito-rbi does that makes sense? For example, in your build.gradle you would specify the latest (or whichever) SDK version : https://github.com/mParticle/react-native-mparticle/blob/main/sample/android/app/build.gradle#L140

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants