Adds MultiTouch Gesture Template and examples using it with zoom in and zoom out #85
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
simonychoy
reviewed
Nov 6, 2024
simonychoy
left a comment
simonychoy
left a comment
There was a problem hiding this comment.
I don't think these scripts work as intended with the current percentages used, unless I am misreading this.
mabl snippets/native mobile testing/mobileZoomInAtScreenCenter.js
Outdated
Show resolved
Hide resolved
mabl snippets/native mobile testing/mobileZoomInAtScreenCenter.js
Outdated
Show resolved
Hide resolved
mabl snippets/native mobile testing/mobileZoomInAtScreenCenter.js
Outdated
Show resolved
Hide resolved
DancingNerd
changed the title
simonychoy
reviewed
Nov 19, 2024
mabl snippets/native mobile testing/customMobileGesturesTemplate.js
Outdated
Show resolved
Hide resolved
mabl snippets/native mobile testing/customMobileGesturesTemplate.js
Outdated
Show resolved
Hide resolved
mabl snippets/native mobile testing/customMobileGesturesTemplate.js
Outdated
Show resolved
Hide resolved
mabl snippets/native mobile testing/customMobileGesturesTemplate.js
Outdated
Show resolved
Hide resolved
Comment on lines
+541
to
+548
| const x = | ||
| (1 - t) * (1 - t) * start.x + | ||
| 2 * (1 - t) * t * control.x + | ||
| t * t * end.x; | ||
| const y = | ||
| (1 - t) * (1 - t) * start.y + | ||
| 2 * (1 - t) * t * control.y + | ||
| t * t * end.y; |
simonychoy
reviewed
Nov 19, 2024
mabl snippets/native mobile testing/customMobileGesturesTemplate.js
Outdated
Show resolved
Hide resolved
simonychoy
approved these changes
Nov 19, 2024
simonychoy
left a comment
simonychoy
left a comment
There was a problem hiding this comment.
LGTM, just have a few minor things to update.
simonychoy
reviewed
Nov 21, 2024
| `const element = new MobileElement();` //=> Create a new element object | ||
| 2. Find the element or get screen information. | ||
| 2. Find the element or just get the screen location and be done. |
There was a problem hiding this comment.
Suggested change
| 2. Find the element or just get the screen location and be done. | |
| 2. Find the element or just get the screen location. |
| const image = await new MobileElement().findByXpath("//XCUIElementTypeImage"); | ||
| await new MultiTouch().zoomIn(image.center).perform(); | ||
| await new MultiTouch().zoomOut(image.center).perform(); | ||
| ## One vertical swipe and one horizontal swipe at the same time |
There was a problem hiding this comment.
I think this is a vertical swipe followed by a horizontal swipe right? Was confused about the "at the same time" phrasing here.
| * @private | ||
| */ | ||
| async waitUntilLoop() { | ||
| this.count++; |
There was a problem hiding this comment.
nit: I think it would be better to name this loopCount to be a bit more descriptive.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.