Adds zoom in and out multi-touch gesture snippets for mobile #85
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
simonychoy
reviewed
Nov 6, 2024
| parameters: { pointerType: "touch" }, | ||
| actions: [ | ||
| // Move the pointer to the left of the center | ||
| { type: "pointerMove", duration: 0, x: center.x * 0.45, y: center.y }, |
There was a problem hiding this comment.
Is this what you intended? The center.x should already be the center of the element, so you are setting the x value here to be 45% of that (so 22.5% of the element width).
| { | ||
| type: "pointerMove", | ||
| duration: 1000, | ||
| x: center.x * 0.35, |
There was a problem hiding this comment.
Based on the percentages used here, this is actually moving away from the center I think?
Comment on lines
+36
to
+43
| { type: "pointerMove", duration: 0, x: center.x * 0.55, y: center.y }, | ||
| // Press down | ||
| { type: "pointerDown", button: 0 }, | ||
| // Move the pointer further to the center over 1000ms | ||
| { | ||
| type: "pointerMove", | ||
| duration: 1000, | ||
| x: center.x * 0.65, |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.