Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for rswift.json config to BuildToolPlugin #896

Conversation

TheNightmanCodeth
Copy link

@TheNightmanCodeth TheNightmanCodeth commented Jun 20, 2024

I noticed there was no way to set custom arguments to the generation command when using SPM or Xcode BuildToolPlugin

This just allows for configuration via a rswift.json file placed at the project root (or elsewhere if it is added manually to the Xcode project)

The config json would look like:

{
    "generators": ["image", "string"],
    "rswiftignorePath": "/Users/TheNightmanCodeth/project/other/.rswiftignore",
    "additionalArguments": ["--somethingelse", "value"]
}

or any variation (ie. only additionalArguments, only generators and rswiftignorePath, etc.)

Addresses #860 (among others)

@fthdgn
Copy link

fthdgn commented Nov 2, 2024

This config file is used only by RswiftGenerateInternalResources plugin. There are also RswiftGenerateResourcesCommand and RswiftGeneratePublicResources plugins.

@TheNightmanCodeth
Copy link
Author

Yeah good call this was a quick solution for a narrow use-case. There's another MR #899 raised just after this that, at a quick glance, appears to fill in those gaps.

I'm going to go ahead and close this since I'm no longer using R.swift and don't plan on coming back to finish this out. If someone else would like to take what I've done and finish it in another MR that's fine with me.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants