Support for Xcode String Catalogs #931
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Of course, after creating this PR I noticed that #886 also exists with an implementation of this. 🤦🏼 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds support for Xcode String Catalogs to R.swift.
The string catalogs are parsed in a similar fashion to Strings files and Strings Dicts. They output the same type, a StringsTable.
What's changed in this PR
StringsTable+Parser.swiftwith support for parsing string catalogs.RswiftParsersTests.StringCatalogAppas an integration test. This is also used in the checks workflow on GitHub Actions.Fixes #840, #861