Skip to content

removed assigning values to new variables from reciever's fields #8

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

removed assigning values to new variables from reciever's fields #8

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
96d820b
simplified N() and Err() method
pavankumar-bit Aug 25, 2020
41a9eda
simplified N() and Err() method
pavankumar-bit Aug 25, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 4 additions & 8 deletions reader.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,18 +34,14 @@ func (r *Reader) Read(p []byte) (n int, err error) {
// N gets the number of bytes that have been read
// so far.
func (r *Reader) N() int64 {
var n int64
r.lock.RLock()
n = r.n
r.lock.RUnlock()
return n
defer r.lock.RUnlock()
return r.n
}

// Err gets the last error from the Reader.
func (r *Reader) Err() error {
var err error
r.lock.RLock()
err = r.err
r.lock.RUnlock()
return err
defer r.lock.RUnlock()
return r.err
}
12 changes: 4 additions & 8 deletions writer.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,18 +34,14 @@ func (w *Writer) Write(p []byte) (n int, err error) {
// N gets the number of bytes that have been written
// so far.
func (w *Writer) N() int64 {
var n int64
w.lock.RLock()
n = w.n
w.lock.RUnlock()
return n
defer w.lock.RUnlock()
return w.n
}

// Err gets the last error from the Writer.
func (w *Writer) Err() error {
var err error
w.lock.RLock()
err = w.err
w.lock.RUnlock()
return err
defer w.lock.RUnlock()
return w.err
}