certbot 3.2.0 wrong paths

[BjarneDMat]

Description

certbot 3.2.0 is looking for the certificates in the wrong place:
Saving debug log to /var/log/letsencrypt/letsencrypt.log
certificate path : /etc/letsencrypt/

The problem w/ the paths was introduced in
408ad4d

Lines 56-61 were removed ; but only line 56 ought to have been removed. lines 58-62 ought only to have had their paths corrected

On branch certbot
Changes to be committed:
modified: security/certbot/Portfile

Type(s)

• [ x] bugfix
• enhancement
• security fix

Tested on

macOS 10.15.7 19H2026 x86_64
Xcode 12.4 12D4e

macOS 14.7.3 23H417 x86_64
Xcode 16.2 16C5032a

Verification

Have you

• followed our Commit Message Guidelines?
• squashed and minimized your commits?
• checked that there aren't other open pull requests for the same change?
• checked your Portfile with port lint?
• tried existing tests with sudo port test?
• tried a full install with sudo port -vst install?
• tested basic functionality of all binary files?
• checked that the Portfile's most important variants haven't been broken?

[macportsbot]

Notifying maintainers:
@Schamschula for port certbot.

[BjarneDMat]

NOTE : you'll still have to downgrade py-josepy to v 1.15.0 to get certbot 3.2.0 to run correctly

[Schamschula]

Just as when py-josepy had already been downgraded once previously, you will again need to increment the epoch.

[Schamschula]

No! certbot doesn't need an epoch increment, py-josepy needs is as we're going from 2.0.0 -> 1.15.0

[Schamschula]

The post patch block is already under the subport ${name} block in the certbot Portfile.

[BjarneDMat]

but it only gets activated iff you aks for the variant - like port install certbot +docs ; not if you just do port install certbot ; we might have to entirely revert that part of the original patch.

[Schamschula]

Yes, you are right. I didn't mean to have it under the +docs variant. However, it is only needed for subport ${name}, not for all the other subports.

[Schamschula]

Almost all good:
However, both certbot and py-acme need a revision bump, as we're changing files.

[BjarneDMat]

I've tested port -cuNn -sd install certbot +docs +python{313,312,311}
python310 fails to build

[Schamschula]

I'm not particularly surprised that Python < 3.11 fails. Particularly 3.9 fails often.

I only build on 3.12 and 3.13 at this point.

[Schamschula]

Let's go with this!

[reneeotten]

@Schamschula so if you're happy with this, then please merge the PR

[Schamschula]

Somehow the CI system had a problem with Augeas under macOS 15.

However, that's not the issue here.

[Schamschula]

For reference, I reported the augeas issue upstream.

See hercules-team/augeas#851