Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

qt6,qt76: provide "upgrade" path on systems where the port is no longer supported #27720

Merged
merged 2 commits into from
Feb 20, 2025

Conversation

reneeotten
Copy link
Contributor

Description

The initial Qt6 port (and updates to newer versions I committed) had the supported versions incorrectly listed. That issue was corrected a while ago, but there are users who had the qt6 port installed on a system that is no longer supported. So instead they should install the qt67 or qt64 (sub)ports.

To provide an "upgrade" path for these situations I added some logic to the Portfiles that will set replaced_by on systems that no longer support the versions provided by the qt6 or qt67 ports.

Type(s)
  • bugfix
  • enhancement
  • security fix
Tested on

macOS x.y
Xcode x.y / Command Line Tools x.y.z

Verification

Have you

  • followed our Commit Message Guidelines?
  • squashed and minimized your commits?
  • checked that there aren't other open pull requests for the same change?
  • referenced existing tickets on Trac with full URL in commit message?
  • checked your Portfile with port lint?
  • tried existing tests with sudo port test?
  • tried a full install with sudo port -vst install?
  • tested basic functionality of all binary files?
  • checked that the Portfile's most important variants haven't been broken?

@macportsbot
Copy link

Notifying maintainers:
@MarcusCalhoun-Lopez for port qt6, qt67.

@macportsbot macportsbot added type: enhancement maintainer maintainer: open Affects an openmaintainer port by: member Created by a member with commit rights labels Feb 20, 2025
@reneeotten
Copy link
Contributor Author

@jmroot would you mind taking a look at this PR and see if I missed anything; I think this should provide an "upgrade" path for systems where the qt6 or qt67 ports are no longer supported.

@jmroot
Copy link
Member

jmroot commented Feb 20, 2025

Looks reasonable to me.

@reneeotten reneeotten merged commit 7c02bd9 into macports:master Feb 20, 2025
0 of 3 checks passed
@reneeotten reneeotten deleted the qt6-upgrade-path branch February 20, 2025 05:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
by: member Created by a member with commit rights maintainer: open Affects an openmaintainer port maintainer type: enhancement
Development

Successfully merging this pull request may close these issues.

4 participants