Allow deleting distfiles if distfiles is a symlink #15
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When I originally prevented deletions if distfiles was a symlink in f151333 I was considering replacing the distfiles directory on each worker with a symlink to the master distfiles volume mounted over AFP/SMB to save disk space on the workers. I didn't end up trying that, but on the Apple Silicon workers I have now made distfiles a symlink to a shared directory where I do want deletions to occur, so I've changed the condition so now deletions can occur unless ports.tar.gz exists; that would only exist on the master. I added a slash to the end of the distfiles path since otherwise find won't descend into the symlinks.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When I originally prevented deletions if distfiles was a symlink in f151333 I was considering replacing the distfiles directory on each worker with a symlink to the master distfiles volume mounted over AFP/SMB to save disk space on the workers. I didn't end up trying that, but on the Apple Silicon workers I have now made distfiles a symlink to a shared directory where I do want deletions to occur, so I've changed the condition so now deletions can occur unless ports.tar.gz exists; that would only exist on the master. I added a slash to the end of the distfiles path since otherwise find won't descend into the symlinks.