This repository was archived by the owner on Jun 19, 2025. It is now read-only.
Environments and Configuration#17
Open
Goldmensch wants to merge 4 commits into
Open
Conversation
Goldmensch
force-pushed
the
feat/environments
branch
from
January 20, 2023 17:22
02ea7b2 to
886caea
Compare
Goldmensch
force-pushed
the
feat/environments
branch
from
January 20, 2023 18:06
886caea to
110eeb0
Compare
Taucher2003
marked this pull request as draft
January 21, 2023 18:19
Goldmensch
force-pushed
the
feat/environments
branch
3 times, most recently
from
January 21, 2023 23:02
65b0415 to
c626e02
Compare
This commit adds plugin configurations, that are specific by the @PluginConfig annotation, generated at compile-time and set up and migrated automatically at runtime. Also, it adds a new preload event, that is fired before the load event (JavaPlugin#onLoad) is fired. After all preload listeners, the environment is refreshed.
Goldmensch
marked this pull request as ready for review
February 8, 2023 14:38
Taucher2003
reviewed
Feb 8, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pr disables the automatic detection of environments, this could cause unexpected behavior and is not really useful in a plugin, furthermore this pr adds the ability to generate a default configuration at compile time, setting it up at runtime and defining migrations.
depends on #13