Skip to content

Modernize FLEX: iOS 16+, remove private APIs, reduce size #1

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
madibb wants to merge 7 commits into
base: master
Choose a base branch
from
Open

Modernize FLEX: iOS 16+, remove private APIs, reduce size #1

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
1c78413
Remove private APIs causing App Store rejection
madibb Jan 8, 2026
4e17213
Silence build warnings when used in Xcode 26 via SwiftPM
madibb Jan 13, 2026
6f8b53f
Reduce library size by ~1.25MB via module removal and SF Symbols migr…
madibb Jan 13, 2026
27a3572
Update minimum deployment target to iOS 16 and remove legacy version …
madibb Jan 13, 2026
d878ba8
Remove obsolete Graphics folder (~3.3MB)
madibb Jan 13, 2026
91feffe
Update SF Symbol icons to match original design
madibb Jan 13, 2026
1a44136
Improve SF Symbol icons and Done button styling
madibb Jan 13, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
55 changes: 26 additions & 29 deletions Classes/Core/Controllers/FLEXNavigationController.m
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -48,41 +48,35 @@ - (void)viewDidLoad {
[self.navigationBar addGestureRecognizer:navbarTapGesture];

// Add gesture to dismiss if not presented with a sheet style
if (@available(iOS 13, *)) {
switch (self.modalPresentationStyle) {
case UIModalPresentationAutomatic:
case UIModalPresentationPageSheet:
case UIModalPresentationFormSheet:
break;

default:
[self addNavigationBarSwipeGesture];
break;
}
} else {
[self addNavigationBarSwipeGesture];
switch (self.modalPresentationStyle) {
case UIModalPresentationAutomatic:
case UIModalPresentationPageSheet:
case UIModalPresentationFormSheet:
break;

default:
[self addNavigationBarSwipeGesture];
break;
}
}

- (void)viewWillAppear:(BOOL)animated {
[super viewWillAppear:animated];

if (@available(iOS 15.0, *)) {
UISheetPresentationController *presenter = self.sheetPresentationController;
presenter.detents = @[
UISheetPresentationControllerDetent.mediumDetent,
UISheetPresentationControllerDetent.largeDetent,
];
presenter.prefersScrollingExpandsWhenScrolledToEdge = NO;
presenter.selectedDetentIdentifier = UISheetPresentationControllerDetentIdentifierLarge;
presenter.largestUndimmedDetentIdentifier = UISheetPresentationControllerDetentIdentifierLarge;
}


UISheetPresentationController *presenter = self.sheetPresentationController;
presenter.detents = @[
UISheetPresentationControllerDetent.mediumDetent,
UISheetPresentationControllerDetent.largeDetent,
];
presenter.prefersScrollingExpandsWhenScrolledToEdge = NO;
presenter.selectedDetentIdentifier = UISheetPresentationControllerDetentIdentifierLarge;
presenter.largestUndimmedDetentIdentifier = UISheetPresentationControllerDetentIdentifierLarge;

if (self.beingPresented && !self.didSetupPendingDismissButtons) {
for (UIViewController *vc in self.viewControllers) {
[self addNavigationBarItemsToViewController:vc.navigationItem];
}

self.didSetupPendingDismissButtons = YES;
}
}
Expand Down Expand Up @@ -132,19 +126,22 @@ - (void)addNavigationBarItemsToViewController:(UINavigationItem *)navigationItem
return;
}

// Check if a done item already exists
// Check if a close/done item already exists (red tinted or xmark image)
for (UIBarButtonItem *item in navigationItem.rightBarButtonItems) {
if (item.style == UIBarButtonItemStyleDone) {
if ([item.tintColor isEqual:UIColor.systemRedColor] || item.image != nil) {
return;
}
}

// Give root view controllers a Done button if it does not already have one
UIImage *closeImage = [UIImage systemImageNamed:@"xmark"];
UIBarButtonItem *done = [[UIBarButtonItem alloc]
initWithBarButtonSystemItem:UIBarButtonSystemItemDone
initWithImage:closeImage
style:UIBarButtonItemStylePlain
target:self
action:@selector(dismissAnimated)
];
done.tintColor = UIColor.systemRedColor;

// Prepend the button if other buttons exist already
NSArray *existingItems = navigationItem.rightBarButtonItems;
Expand Down
Loading