-
Notifications
You must be signed in to change notification settings - Fork 2.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add workflow to build with all available C standards #925
Conversation
Note that the failing automated build checks with the new workflow file are to be expected. |
Are to be expected? What do you mean? |
It just means that this workflow triggers the warnings reported in #926. The compilation in the workflow deliberately uses Given the different behaviour seen with #926 on Mac , I've just added building on Mac to the workflow matrix |
Does this workflow work now? |
Not quite. After your comment about the Microsoft compilers and their continued support for C89, I added more workflow to test the state of play with the C standards they support (c11 & c17). Nothing popped out. Also, I'm trying out 32-bit builds on Linux & Microsoft -- issue #930 was found with that. Should have this some time tomorrow to tidy it up.. |
Alrighty, thanks. |
* Add Windows gcc & cl * Build 32-bit & 64-bit * Tidy up
Latest update now building 100% with develop. The workflow now tests as many C standards as possible with the following
gcc & clang standards are c89, gnu89, c94, c99, gnu99, c11, gnu11, c17, gnu17, c2x, gnu2x cl standards are c11, c17 and clatest This workflow will trigger a total of 173 compilations of If it does become an issue, the workflow can always be disabled for PR's and only run manually. One combination that isn't working, and has been explicitly excluded from the workflow, is Windows + clang + cmake -- created #932 to track that. It is trivial to enable if it gets fixed. |
Missed out C20 with the Microsoft C compiler. Sorted now. |
Where do I find my CPU limit and how much time has been used against it? |
This link https://docs.github.com/en/get-started/learning-about-github/githubs-plans#github-free-for-personal-accounts says that you get 200 minutes/month. If you look in the |
Actually 2000 minutes per month! Thank you for for looking into that. |
* Add Wall/Wextra * Disable C20 on MSVC for now -- not avauilable in the windows runner yet
Today's change does the following
|
What is |
It gets cmake to use ninja instead of make to do the build. Supposed to be faster than make. Used it here to match what was already done in |
Applied. Thank you! |
This workflow gets zlib built with all the C standards that gnu & clang support from c89 through to c2x (i.e. early c23).
It is setup to fail the workflow if there are any compiler warnings (by adding
-Werror
toCFLAGS
)This has highlighted a couple of compiler warnings. Will ticket them separately.