-
Notifications
You must be signed in to change notification settings - Fork 86
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix empty space on assistant responses line when 'virtualedit=all' is set. #148
Fix empty space on assistant responses line when 'virtualedit=all' is set. #148
Conversation
If you decide to merge #151, then this PR is not needed. |
I cannot reproduce it, in my environments there is never a space before the response text. Even from the change you made to the code I don't get what would be a difference. Could you describe more your environment, configuration and steps how you can reproduce it? |
Looks like it's because of |
I see. This would however solve the issue just for the chat, not for I did some quick testing and this combination seems to be working fine for any mode:
|
467e001
to
d626067
Compare
\ "command_type": 'complete', | ||
\ "command_type": 'edit', |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@madox2 this change is unrelated to this PR, but it's useful for my change and looks like an omission after the role changes?
Thank you for testing! |
Looks good, let me fix tests for you |
This make copying easier.
Before this change the AI would respond like this:
Now it responds like this: