Try to send unmodified file paths from the >>> include section
#155
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When sending file paths from the `>>> include` section, try to send file paths as the user typed them instead of expanding them: * When the user provides an absolute path, send it as-is, but replace home dir with `~` to avoid sending the username to API providers. * When the user provides a relative path, send it as a relative path. * When the user provides a glob under a relative path, keep the resulting path relative to the current working dir.
juodumas
referenced
this pull request
Mar 14, 2025
juodumas
commented
Mar 14, 2025
| @@ -154,7 +156,6 @@ def test_parse_include_single_file_message(): | |||
|
|
|||
| try harder | |||
| """) | |||
| messages = parse_chat_messages(chat_content) | |||
There was a problem hiding this comment.
I've removed this (and another one below) because it looks like a leftover.
|
Hi, thank you for the PR!
I am not sure, will this work on windows? I would be also fine if all paths are handled just "as is". |
|
One OS independent manner could be `vim.eval('fnamemodify(...)') since it's used anyway, but I guess Python can handle it as well, but maybe requires more care |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When sending file paths from the
>>> includesection, try to send file paths as the user typed them instead of expanding them:~to avoid sending the username to API providers.This is an attempt to improve #149 based on comments here e375e05#commitcomment-153576019