Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bump tonic version to v0.9 #151

Merged
merged 6 commits into from
Jul 20, 2023

Conversation

xxchan
Copy link
Contributor

@xxchan xxchan commented Jun 29, 2023

... I'm wondering whether we need to bump major version #145

changelog: https://github.com/hyperium/tonic/blob/master/CHANGELOG.md

I mainly want this: build:: Support boxing fields

@wangrunji0408
Copy link
Member

wangrunji0408 commented Jun 29, 2023

... I'm wondering whether we need to bump major version #145

I think it's needed. Tonic has breaking API change from 0.8 to 0.9.

CHANGELOG.md Outdated Show resolved Hide resolved
@xxchan
Copy link
Contributor Author

xxchan commented Jul 5, 2023

Oh, arrow-flight >= 37 also needs it. That's a larger need.

@xxchan
Copy link
Contributor Author

xxchan commented Jul 5, 2023

Although I want to completely understand #153 and #145 first 😅

@ZENOTME
Copy link

ZENOTME commented Jul 18, 2023

Also needed in risingwavelabs/risingwave#10875 for introducing Icelake.

@wangrunji0408 wangrunji0408 marked this pull request as ready for review July 20, 2023 06:21
Signed-off-by: Runji Wang <[email protected]>
Copy link
Member

@wangrunji0408 wangrunji0408 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approve myself. :)
@xxchan please review my change

@wangrunji0408 wangrunji0408 changed the title bump tonic version bump tonic version to v0.9 Jul 20, 2023
@xxchan
Copy link
Contributor Author

xxchan commented Jul 20, 2023 via email

@wangrunji0408 wangrunji0408 merged commit 4e7f8ef into madsim-rs:main Jul 20, 2023
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants