fix: wrap fetch_watermarks in spawn_blocking
#196
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Runji Wang <[email protected]>
|
Is there a plan for other synchronous interfaces as well? 🥺 |
Maybe migrated case by case. 🥹 |
BugenZhao
reviewed
Mar 22, 2024
| let ret = unsafe { | ||
| rdsys::rd_kafka_query_watermark_offsets( | ||
| self.native_ptr(), | ||
| let native_client = unsafe { NativeClient::from_ptr(self.native_ptr()) }; |
There was a problem hiding this comment.
NativeClient will call rd_kafka_destroy when it's get dropped (behavior of NativePtr). Will this lead to problem?
There was a problem hiding this comment.
Ohhh. I think so. Thanks for your troubleshooting!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please take a look. @BugenZhao @tabVersion
Will release as madsim-rdkafka v0.3.3.