feat(app-tracking): add permission on startup #20
Conversation
dargmuesli
changed the title
vibetype/ViewController.swift
Outdated
|
|
||
|
|
||
|
|
||
|
|
||
|
|
||
|
|
||
|
|
||
|
|
There was a problem hiding this comment.
What's going on with the indentations and line breaks ;D
There was a problem hiding this comment.
Reformatted, you can resolve if code looks good to you still
dargmuesli
force-pushed
the
fix/add-apptracking-permission
branch
from
0c663f1 to
796e58a
Compare
vibetype/WebView.swift
Outdated
| @@ -2,6 +2,8 @@ import UIKit | |||
| @preconcurrency import WebKit | |||
| import AuthenticationServices | |||
| import SafariServices | |||
| import AppTrackingTransparency | |||
| import FirebaseCore | |||
There was a problem hiding this comment.
Why is FirebaseCore needed here now?
There was a problem hiding this comment.
Pod Installation was breaking for me without this, I am not sure if this is also required for production.
There was a problem hiding this comment.
Hmm, pod installation should not depend on this source code, could you verify?
| if message.name == "print" { | ||
| func returnTrackingPermissionResult(isAuthorized: Bool) { | ||
| let result = isAuthorized ? "authorized" : "denied" | ||
| dispatchEventToWebView(name: "tracking-permission-request", data: result) |
There was a problem hiding this comment.
How would we listen for this in the maevsi/vibetype? Using the service worker?
There was a problem hiding this comment.
I've added listener for this here maevsi/vibetype@70990f4
…cceptance" This reverts commit a69f23c.
This PR