feat(postgraphile): remove forward authentication middleware#270
Merged
Conversation
d992a94 to
b99c38b
Compare
There was a problem hiding this comment.
Pull request overview
Removes the Traefik forward authentication middleware for Postgraphile, since Turnstile validation is now handled by a Postgraphile preset in the upstream image (v2.1.0).
Changes:
- Drop
postgraphile_authforwardauth middleware definition from development stack. - Update router middleware lists to no longer reference
postgraphile_auth. - Bump postgraphile image from 2.0.5 to 2.1.0 in production.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| src/development/stack.yml | Removes forwardauth middleware definition and reference from secure router. |
| src/production/production.yml | Replaces postgraphile_auth with redirectscheme in router middleware list and bumps image to 2.1.0. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
|
🎉 This PR is included in version 18.3.0 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
There is now a Postgraphile preset which validates turnstile:
Thus, the traefik middleware is no longer needed.