You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Had to upgrade standard because older version complained about use of TextDecoder.
It is worth pointing out that TextDecoder / TextEncoder had being added in node 11 as far as I can tell. If that is a concern I can update code to import those from utils.
Is this critical for you? Otherwise I’d prefer to wait until 10 goes EOL, to avoid too massive breakage.
No rush, I have plenty of other places I need to prune of node Buffers, so this can wait until 10 goes EOL.
My guess would be that util adds much more overhead than Buffer
That is also why I was hesitent to do that.
Part of me also just wishes this lib was just taking string and did not concern itself with buf.toString() but that probably is too big of a change to be worth it.
I’d prefer to wait until 10 goes EOL, to avoid too massive breakage.
Guess it's time now
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #52
Had to upgrade standard because older version complained about use of
TextDecoder.It is worth pointing out that
TextDecoder/TextEncoderhad being added in node 11 as far as I can tell. If that is a concern I can update code to import those fromutils.