Open
Conversation
Takes the types from [@types/protocol-buffers-schema](https://www.npmjs.com/package/@types/protocol-buffers-schema) and adds them to this module. It swaps node `Buffer`s for `Uint8Array`s in the interfaces because this module doesn't use any `Buffer` features that aren't available on `Uint8Array`s which makes it a bit kinder to the browser.
achingbrain
force-pushed
the
feat/add-types
branch
from
a1a4954 to
1bc5816
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Takes the types from @types/protocol-buffers-schema and adds them to this module.
It swaps node
Buffers forUint8Arrays in the interfaces because this module doesn't use anyBufferfeatures that aren't available onUint8Arrays which makes it a bit kinder to the browser.