Expose presence of explicit optional keyword on fields#69
Open
mwatson2 wants to merge 1 commit intomafintosh:masterfrom
Open
Expose presence of explicit optional keyword on fields#69mwatson2 wants to merge 1 commit intomafintosh:masterfrom
mwatson2 wants to merge 1 commit intomafintosh:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Whilst all fields in proto3 are optional, in the sense that they can be omitted from the message serialization, the
optionalkeyword still carries a meaning. For fields that are not explicitly markedoptionalthen when the field is missing from a message this is considered equivalent to the field being present with default value. APIs need not distinguish these two cases. When fields are explicitly markedoptional(or if they are in aoneof) then the field missing case is a separate case from present-with-default-value case.It would therefore be useful to expose whether a field is explicitly marked as
optionalin the parsed data structure.This PR adds a property
optionalin the field structure that, if present and true, indicates that the field was marked explicitly as optional, or inside aoneof.