Fixed protobuf imports with respect to root_dir#13
Open
bydga wants to merge 1 commit intomafintosh:masterfrom
Open
Fixed protobuf imports with respect to root_dir#13bydga wants to merge 1 commit intomafintosh:masterfrom
bydga wants to merge 1 commit intomafintosh:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is one of 2 pull requests across protocol-buffer and resolve-protobuf-schema repositories that fixes imports of external protobuf files. now you can specify root_dir that defines base place from where all files are looked-up (as defined in protobuf specification: https://developers.google.com/protocol-buffers/docs/proto#other.
You need to test it together with mafintosh/protocol-buffers-schema#6.