Conversation
mafintosh
reviewed
Mar 22, 2022
mafintosh
reviewed
Mar 22, 2022
mafintosh
reviewed
Mar 22, 2022
mafintosh
reviewed
Mar 22, 2022
Owner
|
Import logic looks fine 👍 Major bump due to the |
martinheidegger
force-pushed
the
imports
branch
from
3a4fc57 to
3a12232
Compare
Owner
|
Remove the use-strict stuff also. That might create unintended behaivor (I doubt it will but also don't have bandwidth to research that). Just move to lts for Node, this means major bumping anyway. |
Owner
|
Other than that good to go. |
Contributor
Author
|
As far as I saw the project is backwards compatible to Node 4 and by using 'use strict', it would stay that way?! |
Owner
|
It's a major bump anyway, so might as well just drop the ancient versions. |
Contributor
Author
|
👍 Do you mind merging #84 |
martinheidegger
force-pushed
the
imports
branch
2 times, most recently
from
f0e3bb2 to
b86a89e
Compare
Contributor
Author
|
Tests pass, I think it's ready. |
Owner
|
@martinheidegger thanks! this seems to conflict now that I merged your other PR |
martinheidegger
force-pushed
the
imports
branch
from
b86a89e to
20ec2ec
Compare
Contributor
Author
|
Rebased. |
Owner
|
🚀 |
Owner
|
5.0.0 |
Contributor
Author
|
🥳 Thanks a lot! This probably also closes: #45 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Note: based on #85 (standard.js update)
This PR adds tested support for
importstatements. During the implementation I looked to make sure that it works somehow similar to the specification.Currently
protocol-buffers-schemadoesn't supportpublic/weakmodifiers**, which means of the 3 ways this could be implemented I chose one. For the simplicity of the PR I went with treating all imports aspublic. This allowed for a simple/working implementation.**→ PR's to support it in protocol-buffers-schema#66 and ...#67This PR comes with support for
-Iand--proto_pathin the CLI to specify the source path, tests and documentation.