Full-Legacy support #307
Open
Full-Legacy support #307
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…butes, flags etc. if wished.
…required strictly sometimes
Travja
approved these changes
Nov 8, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
added a 'full-legacy' configuration to avoid divinity modifying attributes, flags etc. if wished.
In my scenario we migrated our custom-item plugin to divinity. The combat hnadling and related stuff however had big impact and caused some bugs as wrong bow damage, sharpness, damage, no correct attribute behaviour, etc.
The
full-legacyparameter is meant to just exclude all the handling if you are aware of the impact for your server and dont use divinity combat mechanics. It is by default set tofalse. I wasnt sure if I should merge it together with the existentlegacy-combatparam or not. But if you think it makes sense, I can change this without problems.