Initial implementation of DangerCI #28
Conversation
DrewML
force-pushed
the
danger
branch
29 times, most recently
from
e29dd57 to
80f257a
Compare
DrewML
changed the title
| ); | ||
| // prettier-ignore | ||
| const failSummary = failedTests.map(t => | ||
| `<details> |
There was a problem hiding this comment.
This is ugly right now, but couldn't use dedent like I normally do because of this bug: danger/danger-js#557.
Will open a PR later
| "clean": "rimraf dist", | ||
| "lint": "eslint 'src/**/*.js'", | ||
| "prettier": "prettier --write '{src/**/,scripts/**/,}*.js'", | ||
| "prettier:check": "prettier-check '{src/**/,scripts/**/,}*.js'", | ||
| "prettier:check": "prettier --list-different '{src/**/,scripts/**/,}*.js'", |
There was a problem hiding this comment.
We were using prettier-check to make it exit with code 1, but now that we're doing it in danger we don't need that anymore.
| "enzyme": "^3.2.0", | ||
| "enzyme-adapter-react-16": "^1.1.0", | ||
| "eslint": "^4.12.1", | ||
| "eslint-plugin-jsx-a11y": "^6.0.2", | ||
| "eslint-plugin-react": "^7.5.1", | ||
| "execa": "^0.10.0", |
There was a problem hiding this comment.
Because child_process.exec doesn't put the local bin in node_modules in the path by default, and execa handles the windows compat problems
|
|
||
| general: | ||
| artifacts: | ||
| - "coverage/lcov-report" | ||
|
|
||
| dependencies: |
There was a problem hiding this comment.
CircleCI does not allow you to selectivity expose sensitive environment variables to certain branches only. So for security reasons, I had to disable auto deployment to npm, and I removed our token from Circle.
There was a problem hiding this comment.
There was a problem hiding this comment.
We could patch this with a little now deployment of some webhook responder, if it would really help your preferred workflow.
There was a problem hiding this comment.
Yeah, we could do that at some point. Other option would be to migrate to Travis CI, which has support for this.
dangerfile.js
Outdated
| const { fail } = require('danger'); | ||
|
|
||
| const fromRoot = path => path.replace(`${process.cwd()}/`, ''); | ||
| const codeFence = str => `\`\`\`\n${str.trim()}\n\`\`\``; |
There was a problem hiding this comment.
Yikes. ${'```'}\n${str.trim()}\n${'```'}, perhaps?
Maybe even set the backticks to a variable, just for readability. ${fence}\n${str.trim()}\n${fence}
|
|
||
| function eslintCheck() { | ||
| try { | ||
| execa.sync('npm', ['run', '--silent', 'lint', '--', '-f', 'json']); |
There was a problem hiding this comment.
What does this boil down to? npm run --silent lint -- -f json?
There was a problem hiding this comment.
-
npm run --silentprevents npm from spitting any of its own info tostdout(it normally shows the command you ran, and spits info tostderron failures, which we don't want) -
--tellsnpmto pass all other arguments past that point directly to the command being runAs of [email protected], you can use custom arguments when executing scripts. The special option -- is used by getopt to delimit the end of the options. npm will pass all the arguments after the -- directly to your script.
-
-f jsonis shorthand for--format json, which gives us parseable output from the ESLint CLI.
|
|
||
| general: | ||
| artifacts: | ||
| - "coverage/lcov-report" | ||
|
|
||
| dependencies: |
There was a problem hiding this comment.
We could patch this with a little now deployment of some webhook responder, if it would really help your preferred workflow.
Previews
