Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add gRPC module #348

Merged
merged 19 commits into from
Oct 8, 2020
Merged

add gRPC module #348

merged 19 commits into from
Oct 8, 2020

Conversation

mslabko
Copy link
Member

@mslabko mslabko commented Sep 28, 2020 •
edited by RuslanKostiv1
Loading

Description (*)

Related Pull Requests

duhon/magento-docker#24
https://github.com/magento-commerce/magento2-infrastructure/pull/1322

Fixed Issues (if relevant)

  1. Fixes Add gRPC module to Catalog Storefront repo #356

Questions or comments

Code Review Checklist (*)

See dataied checklist

  • Story AC is completed
  • proposed changes correspond to Magento Technical Vision
  • new or changed code is covered with web-api/integration tests (if applicable)
    • expected results in test verified with data from fixture
  • no backward incompatibile changes
  • Export API (et_schema.xml) and SF API schemas (proto schema) are reflected in the codebase
    • prerequisite: story branch created with all needed generated classes according to proposes schema-changes
    • DTO classes do not contain any manual changes (Magento\CatalogExportApi*, Magento\CatalogStorefrontApi*)
  • Class usage: magento/catalog-storefront repo don't use directly classes from magento/saas-export repo and vise-verse
    • Check composer.json dependencies
  • Legacy code is deleted
    • Any Data Providers present in Connector part (Magento\CatalogStorefrontConnector, Magento*Extractor modules)
    • And Data Providers from Export API (magento/saas-export repo) that is not relevant anymore
    • Any DTO for Export API/SF API which does not reflect current schema: et_schema, proto schema
    • Any “mapper” on Message Broker (between Export API and SF API)
      • if mapper still needed, verify fields used in mapping, remove not relevant fields

@mslabko
Copy link
Member Author

mslabko commented Sep 28, 2020

@magento run all tests

@RuslanKostiv1
Copy link
Contributor

RuslanKostiv1 commented Sep 28, 2020 •
edited
Loading

Functional tests run

13:03:18 [Build Functional EE] Enabling maintenance mode
13:03:32 [Build Functional EE] Starting compilation
13:03:45 [Build Functional EE] Something went wrong while compiling generated code. See the error log for details.
13:03:45 [Build Functional EE] Disabling maintenance mode
......
[2020-09-28 18:03:45] report.ERROR: /usr/bin/php -f /var/www/html/bin/magento setup:di:compile 2>&1
Started gRPC code generation...
protoc binary is missing or not in include path. [] []

A lots of static tests failures too

@mslabko
Copy link
Member Author

mslabko commented Sep 28, 2020

@magento run Unit Tests

1 similar comment
@mslabko
Copy link
Member Author

mslabko commented Sep 28, 2020

@magento run Unit Tests

@magento-engcom-team magento-engcom-team mentioned this pull request Sep 29, 2020
Closed
@RuslanKostiv1
Copy link
Contributor

@magento run all tests

@RuslanKostiv1
Copy link
Contributor

@magento run all tests

@RuslanKostiv1
Copy link
Contributor

@magento run all tests

@RuslanKostiv1
Copy link
Contributor

@magento run all tests

@RuslanKostiv1
Copy link
Contributor

@magento run all tests

@RuslanKostiv1 RuslanKostiv1 linked an issue Oct 1, 2020 that may be closed by this pull request
Add gRPC module to Catalog Storefront repo #356
Closed
@RuslanKostiv1
Copy link
Contributor

@magento run all tests

@RuslanKostiv1
Copy link
Contributor

@magento run all tests

@RuslanKostiv1
Copy link
Contributor

@magento run all tests

@RuslanKostiv1
Copy link
Contributor

@magento run all tests

@RuslanKostiv1 RuslanKostiv1 mentioned this pull request Oct 5, 2020
Merged
7 tasks
@RuslanKostiv1
Copy link
Contributor

@magento run all tests

@RuslanKostiv1
Copy link
Contributor

@magento run all tests

@RuslanKostiv1
Copy link
Contributor

@magento run Static Tests

@RuslanKostiv1
Copy link
Contributor

@magento run all tests

@RuslanKostiv1
Copy link
Contributor

@magento run Static Tests

@RuslanKostiv1
Copy link
Contributor

@magento run Static Tests, Unit Tests

@RuslanKostiv1
Copy link
Contributor

@magento run Static Tests

@RuslanKostiv1 RuslanKostiv1 merged commit 22568c3 into develop Oct 8, 2020
@RuslanKostiv1
Copy link
Contributor

@magento run Static Tests

@RuslanKostiv1
Copy link
Contributor

@magento run all tests

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add gRPC module to Catalog Storefront repo
2 participants
@mslabko @RuslanKostiv1