-
Notifications
You must be signed in to change notification settings - Fork 254
Load product salability data on demand #3203
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
swnsma
wants to merge
13
commits into
product-salability-improvements
from
load-product-salability-data-on-demand
Closed
Load product salability data on demand #3203
swnsma
wants to merge
13
commits into
product-salability-improvements
from
load-product-salability-data-on-demand
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
@magento run all tests |
Closed
Apply code review changes.
Move bundle status check to plugin. Move configurable plugin to around. Both facts comes from fact for bundle and configurable produts, salability status is depends only on salability status of their children (and does not depend on the condition chain).
Add GraphQl support for products assignment intersection.
Incapsulate internal logic in single class and expose extension point for extension attributes.
Apply code review changes.
2705aad to
5818efe
Compare
Contributor
|
@magento run Integration Tests |
Contributor
|
@magento run Static Tests |
Contributor
|
Let's close it in favor of #3208 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description (*)
Stop stock data load on after load event.
Inheritance of #3039
See #3202
Fixed Issues (if relevant)
Contribution checklist (*)