Require a strict_types declaration #488
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Copilot reviewed 55 out of 75 changed files in this pull request and generated no comments.
Files not reviewed (20)
- Magento2/Helpers/Commenting/PHPDocFormattingValidator.php: Language not supported
- Magento2/Helpers/Tokenizer/AbstractTokenizer.php: Language not supported
- Magento2/Helpers/Tokenizer/Parameter.php: Language not supported
- Magento2/Helpers/Tokenizer/Variable.php: Language not supported
- Magento2/Sniffs/Classes/AbstractApiSniff.php: Language not supported
- Magento2/Sniffs/Classes/DiscouragedDependenciesSniff.php: Language not supported
- Magento2/Sniffs/CodeAnalysis/EmptyBlockSniff.php: Language not supported
- Magento2/Sniffs/Commenting/ClassAndInterfacePHPDocFormattingSniff.php: Language not supported
- Magento2/Sniffs/Commenting/ConstantsPHPDocFormattingSniff.php: Language not supported
- Magento2/Sniffs/Exceptions/DirectThrowSniff.php: Language not supported
- Magento2/Sniffs/Exceptions/ThrowCatchSniff.php: Language not supported
- Magento2/Sniffs/Exceptions/TryProcessSystemResourcesSniff.php: Language not supported
- Magento2/Sniffs/Functions/DiscouragedFunctionSniff.php: Language not supported
- Magento2/Sniffs/Functions/StaticFunctionSniff.php: Language not supported
- Magento2/Sniffs/GraphQL/AbstractGraphQLSniff.php: Language not supported
- Magento2/Sniffs/GraphQL/ValidArgumentNameSniff.php: Language not supported
- Magento2/Sniffs/GraphQL/ValidEnumValueSniff.php: Language not supported
- Magento2/Sniffs/GraphQL/ValidFieldNameSniff.php: Language not supported
- Magento2/Sniffs/GraphQL/ValidTopLevelFieldNameSniff.php: Language not supported
- Magento2/Sniffs/GraphQL/ValidTypeNameSniff.php: Language not supported
ihor-sviziev
approved these changes
Feb 13, 2025
magento-ct-gh-projects-svc
added
Progress: approved
and removed
Progress: ready for review
labels
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #33
The current
composer.jsonfile requires version 3.6.1 or better of PHP_CodeSniffer. That version and versions up to 3.7.2 only check that there is a declaration, but not if the declaration is setting the feature on/off. From version 3.8.0 onwards, the sniff also asserts that the feature is enabled. While this is a useful feature, I'm undecided if the minimum version for PHP_CodeSniffer should be increased as part of this pull request.