Skip to content

Remove deprecated framework interfaces #735

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 2 commits into from
Closed

Remove deprecated framework interfaces #735

wants to merge 2 commits into from

Conversation

@vlmed
Copy link

@vlmed vlmed commented Mar 1, 2021 •
edited
Loading

Description (*)

Fix dependencies on the following interfaces:

  • lib/internal/Magento/Framework/Option/ArrayInterface.php
  • lib/internal/Magento/Framework/Session/SidResolverInterface.php
  • Removed plugin app/code/Magento/PageBuilder/Plugin/Framework/Session/SidResolver.php

Fixed Issues (if relevant)

  1. Fixes Remove deprecated framework interfaces magento2#32062

Related Pull Requests

magento/magento2#32328
https://github.com/magento/partners-magento2ee/pull/512
magento/inventory#3294
https://github.com/magento/partners-magento2b2b/pull/558
https://github.com/magento/magento2-page-builder-ee/pull/187

Checklist

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds are green)

This was referenced Mar 1, 2021
Closed
Open
Closed
Open
@magento-automated-testing
Copy link

The requested builds are added to the queue. You should be able to see them here within a few minutes. Please re-request them if they don't show in a reasonable amount of time.

2 similar comments
@magento-automated-testing
Copy link

The requested builds are added to the queue. You should be able to see them here within a few minutes. Please re-request them if they don't show in a reasonable amount of time.

@magento-automated-testing
Copy link

The requested builds are added to the queue. You should be able to see them here within a few minutes. Please re-request them if they don't show in a reasonable amount of time.

@bgorski bgorski mentioned this pull request May 30, 2021
Closed
5 tasks
@magento-automated-testing
Copy link

The requested builds are added to the queue. You should be able to see them here within a few minutes. Please re-request them if they don't show in a reasonable amount of time.

3 similar comments
@magento-automated-testing
Copy link

The requested builds are added to the queue. You should be able to see them here within a few minutes. Please re-request them if they don't show in a reasonable amount of time.

@magento-automated-testing
Copy link

The requested builds are added to the queue. You should be able to see them here within a few minutes. Please re-request them if they don't show in a reasonable amount of time.

@magento-automated-testing
Copy link

The requested builds are added to the queue. You should be able to see them here within a few minutes. Please re-request them if they don't show in a reasonable amount of time.

@sidolov sidolov added Priority: P3 Priority: P3 Priority: P1 Priority: P1 and removed Priority: P3 Priority: P3 labels Oct 5, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

2 more reviewers

@bgorski bgorski bgorski approved these changes

@ihor-sviziev ihor-sviziev ihor-sviziev approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@bgorski bgorski

Labels

Partner: Atwix partners-contribution Priority: P1 Priority: P1

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@vlmed @bgorski @ihor-sviziev @sidolov @magento-engcom-team @magento-devops-reposync-svc