Skip to content

Fix validate-emails rule for ui component #33470

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 10 commits into from
Aug 4, 2025
Merged

Fix validate-emails rule for ui component #33470

Changes from all commits
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
2178204
Fix validate-emails rule for ui component
tuanpht Jul 13, 2021
dc7a688
Remove comment
tuanpht Jul 16, 2021
9fddc84
Merge branch '2.4-develop' into fix-validate-emails-rule
engcom-Lima Jul 18, 2023
cddfb65
Merge branch '2.4-develop' into fix-validate-emails-rule
engcom-Dash Oct 15, 2024
49788b3
33470: Suppress ESLint warning for unnecessary escape character
engcom-Dash Oct 18, 2024
bd3d200
Merge branch '2.4-develop' into fix-validate-emails-rule
engcom-Dash Oct 18, 2024
76cff2f
Merge branch '2.4-develop' into fix-validate-emails-rule
engcom-Dash Jul 21, 2025
5c283af
Merge branch '2.4-develop' into fix-validate-emails-rule
engcom-Dash Jul 22, 2025
5616ea7
Fixed static failures
engcom-Dash Jul 22, 2025
eab5e9b
Merge branch '2.4-develop' into fix-validate-emails-rule
engcom-Dash Jul 30, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 6 additions & 4 deletions app/code/Magento/Ui/view/base/web/js/lib/validation/rules.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,12 +1,14 @@
/**
* Copyright © Magento, Inc. All rights reserved.
* See COPYING.txt for license details.
* Copyright 2014 Adobe
* All Rights Reserved.
*/
/* eslint-disable no-useless-escape */
// jscs:disable no-useless-escape
/**
* @api
*/

/* eslint-disable no-useless-escape */
define([
'jquery',
'underscore',
Expand Down Expand Up @@ -893,11 +895,11 @@ define([
if (utils.isEmpty(value)) {
return true;
}
validRegexp = /^[a-z0-9\._-]{1,30}@([a-z0-9_-]{1,30}\.){1,5}[a-z]{2,4}$/i;
validRegexp = /^([a-z0-9,!\#\$%&'\*\+\/=\?\^_`\{\|\}~-]|[\u00A0-\uD7FF\uF900-\uFDCF\uFDF0-\uFFEF])+(\.([a-z0-9,!\#\$%&'\*\+\/=\?\^_`\{\|\}~-]|[\u00A0-\uD7FF\uF900-\uFDCF\uFDF0-\uFFEF])+)*@([a-z0-9-]|[\u00A0-\uD7FF\uF900-\uFDCF\uFDF0-\uFFEF])+(\.([a-z0-9-]|[\u00A0-\uD7FF\uF900-\uFDCF\uFDF0-\uFFEF])+)*\.(([a-z]|[\u00A0-\uD7FF\uF900-\uFDCF\uFDF0-\uFFEF]){2,})$/i; //eslint-disable-line max-len
emails = value.split(/[\s\n\,]+/g);

for (i = 0; i < emails.length; i++) {
if (!validRegexp.test(emails[i].strip())) {
if (!validRegexp.test(emails[i].trim())) {
return false;
}
}
Expand Down