Skip to content

Update \Magento\Email\Model\Transport::setReturnPath to use the exist… #39881

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: 2.4-develop
Choose a base branch
from

Conversation

TomashKhamlai
Copy link
Contributor

Description (*)

An issue was identified where the Sender header is not following RFC 2822 while Symfony does follow

Update \Magento\Email\Model\Transport::setReturnPath to use the existing logic defined in Headers.php v6.4.19

Related Pull Requests

Fixed Issues (if relevant)

  1. Fixes Symfony\Component\Mime\Exception\LogicException: The "Sender" header must be an instance of "Symfony\Component\Mime\Header\MailboxHeader" (got "Symfony\Component\Mime\Header\MailboxListHeader") #39823

Manual testing scenarios (*)

  1. Log in to your Magento Admin Panel.
  2. Navigate to Stores.
  3. Go to Configuration.
  4. Select Advanced. In the left-hand sidebar, scroll down and click on "Advanced".
  5. Choose System. Under the "Advanced" section, click on "System".
  6. Expand Mail Sending Settings. On the "System" configuration page, expand the "Mail Sending Settings" section.
  7. Locate the "Set Return Path" Option. Here, you will find the "Set Return Path" setting.

Questions or comments

Contribution checklist (*)

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • README.md files for modified modules are updated and included in the pull request if any README.md predefined sections require an update
  • All automated tests passed successfully (all builds are green)

Copy link

m2-assistant bot commented May 1, 2025

Hi @TomashKhamlai. Thank you for your contribution!
Here are some useful tips on how you can test your changes using Magento test environment.
❗ Automated tests can be triggered manually with an appropriate comment:

  • @magento run all tests - run or re-run all required tests against the PR changes
  • @magento run <test-build(s)> - run or re-run specific test build(s)
    For example: @magento run Unit Tests

<test-build(s)> is a comma-separated list of build names.

Allowed build names are:
  1. Database Compare
  2. Functional Tests CE
  3. Functional Tests EE
  4. Functional Tests B2B
  5. Integration Tests
  6. Magento Health Index
  7. Sample Data Tests CE
  8. Sample Data Tests EE
  9. Sample Data Tests B2B
  10. Static Tests
  11. Unit Tests
  12. WebAPI Tests
  13. Semantic Version Checker

You can find more information about the builds here
ℹ️ Run only required test builds during development. Run all test builds before sending your pull request for review.


For more details, review the Code Contributions documentation.
Join Magento Community Engineering Slack and ask your questions in #github channel.

@TomashKhamlai
Copy link
Contributor Author

@magento run Magento Health Index

@TomashKhamlai
Copy link
Contributor Author

@magento run Static Tests

@TomashKhamlai
Copy link
Contributor Author

@magento run all tests

@TomashKhamlai
Copy link
Contributor Author

@magento run Unit Tests

Copy link

Failed to run the builds. Please try to re-run them later.

@TomashKhamlai
Copy link
Contributor Author

@magento run Sample Data Tests CE

Copy link

Failed to run the builds. Please try to re-run them later.

@TomashKhamlai
Copy link
Contributor Author

@magento run Sample Data Tests CE

Copy link

Failed to run the builds. Please try to re-run them later.

@TomashKhamlai
Copy link
Contributor Author

Later, like in 2026?!

@magento you are hilarious! Stop dragging your feet and get the tests done!

@TomashKhamlai
Copy link
Contributor Author

@magento run all tests

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
1 participant