-
Notifications
You must be signed in to change notification settings - Fork 9.4k
Clarified Attribute Option already exists response #39941
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Clarified Attribute Option already exists response #39941
Conversation
|
Hi @J0rdyV. Thank you for your contribution!
Allowed build names are:
You can find more information about the builds here For more details, review the Code Contributions documentation. |
|
@magento run all tests |
|
@magento create issue |
lbajsarowicz
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
✅ It's just a typo.
|
@magento run all tests |
|
Hi @J0rdyV, Thanks for your Contribution!!. Could you please elaborate the steps to reproduce to reproduce and confirm the issue as per the process if possible please provide screenshots to proceed further. Thanks. |
|
Hey @engcom-Bravo , This happens when you try to create an attribute option twice with the same value on the post endpoint. |
|
@magento run all tests |
|
Hi @J0rdyV, Thanks for the collaboration & contribution! ✔️ QA PassedPreconditions:
Steps to reproduce Try to create an attribute option twice with the same value on the post endpoint. Before: ✖️
After: ✔️
Builds are failed. Hence, moving this PR to Extended Testing. Thanks. |
|
@magento run all tests |
|
@magento run all tests |
|
@magento run all tests |
|
@engcom-Bravo This was a simple typo.. Do changes always take so long to be merged? |
|
@magento run all tests |
|
@magento run Functional Tests B2B, Functional Tests EE |
|
The B2B and EE failures are inconsistent and flaky. They neither part of the PR nor failing because of the PR changes. B2B Build 2 EE Build 2 Hence, Moving this PR to Merge In Progress |
667cb34
into
magento:2.4-develop






Description (*)
Replaced the awkward phrase "Get new file name if the same is already exists" with a clearer and grammatically correct version: "Get a new file name if one already exists." This improves readability and user understanding.
Same for the attribute option response.
Manual testing scenarios (*)
Questions or comments
First time PR to Magento. Please let me know if i need to do something else.
Contribution checklist (*)
Resolved issues: