Skip to content

Conversation

@J0rdyV
Copy link
Contributor

@J0rdyV J0rdyV commented May 27, 2025

Description (*)

Replaced the awkward phrase "Get new file name if the same is already exists" with a clearer and grammatically correct version: "Get a new file name if one already exists." This improves readability and user understanding.
Same for the attribute option response.

Manual testing scenarios (*)

  1. pushing an already existing attribute option to the attribute option api endpoint.

Questions or comments

First time PR to Magento. Please let me know if i need to do something else.

Contribution checklist (*)

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • README.md files for modified modules are updated and included in the pull request if any README.md predefined sections require an update
  • All automated tests passed successfully (all builds are green)

Resolved issues:

  1. resolves [Issue] Clarified Attribute Option already exists response #39943: Clarified Attribute Option already exists response

@m2-assistant
Copy link

m2-assistant bot commented May 27, 2025

Hi @J0rdyV. Thank you for your contribution!
Here are some useful tips on how you can test your changes using Magento test environment.
❗ Automated tests can be triggered manually with an appropriate comment:

  • @magento run all tests - run or re-run all required tests against the PR changes
  • @magento run <test-build(s)> - run or re-run specific test build(s)
    For example: @magento run Unit Tests

<test-build(s)> is a comma-separated list of build names.

Allowed build names are:
  1. Database Compare
  2. Functional Tests CE
  3. Functional Tests EE
  4. Functional Tests B2B
  5. Integration Tests
  6. Magento Health Index
  7. Sample Data Tests CE
  8. Sample Data Tests EE
  9. Sample Data Tests B2B
  10. Static Tests
  11. Unit Tests
  12. WebAPI Tests
  13. Semantic Version Checker

You can find more information about the builds here
ℹ️ Run only required test builds during development. Run all test builds before sending your pull request for review.


For more details, review the Code Contributions documentation.
Join Magento Community Engineering Slack and ask your questions in #github channel.

@J0rdyV
Copy link
Contributor Author

J0rdyV commented May 27, 2025

@magento run all tests

@engcom-Hotel
Copy link
Contributor

@magento create issue

Copy link
Contributor

@lbajsarowicz lbajsarowicz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ It's just a typo.

@J0rdyV
Copy link
Contributor Author

J0rdyV commented Aug 12, 2025

@magento run all tests

@engcom-Bravo
Copy link
Contributor

Hi @J0rdyV,

Thanks for your Contribution!!.

Could you please elaborate the steps to reproduce to reproduce and confirm the issue as per the process if possible please provide screenshots to proceed further.

Thanks.

@J0rdyV
Copy link
Contributor Author

J0rdyV commented Sep 2, 2025

Hey @engcom-Bravo ,

This happens when you try to create an attribute option twice with the same value on the post endpoint.

https://adobe-commerce.redoc.ly/2.4.8-admin/tag/productsattributesattributeCodeoptions#operation/PostV1ProductsAttributesAttributeCodeOptions

@engcom-Bravo
Copy link
Contributor

@magento run all tests

@engcom-Bravo
Copy link
Contributor

Hi @J0rdyV,

Thanks for the collaboration & contribution!

✔️ QA Passed

Preconditions:

  • Install fresh Magento 2.4-develop

Steps to reproduce

Try to create an attribute option twice with the same value on the post endpoint.

Before: ✖️ 

Screenshot 2025-09-04 at 4 02 48 pm

After: ✔️

Screenshot 2025-09-04 at 4 07 55 pm

Builds are failed. Hence, moving this PR to Extended Testing.

Thanks.

@engcom-Bravo engcom-Bravo moved this from Testing in Progress to Extended Testing (optional) in Pull Requests Dashboard Sep 5, 2025
@J0rdyV
Copy link
Contributor Author

J0rdyV commented Sep 16, 2025

@magento run all tests

@engcom-Dash engcom-Dash self-assigned this Oct 15, 2025
@engcom-Dash
Copy link
Contributor

engcom-Dash commented Oct 15, 2025

@magento run all tests

@engcom-Dash
Copy link
Contributor

@magento run all tests

@J0rdyV
Copy link
Contributor Author

J0rdyV commented Oct 21, 2025

@engcom-Bravo This was a simple typo.. Do changes always take so long to be merged?

@Priyakshic Priyakshic added the Project: Community Picked PRs upvoted by the community label Dec 11, 2025
@Priyakshic Priyakshic moved this to Extended testing (optional) in Community Dashboard Dec 11, 2025
@engcom-Dash
Copy link
Contributor

@magento run all tests

@engcom-Dash
Copy link
Contributor

@magento run Functional Tests B2B, Functional Tests EE

@engcom-Dash engcom-Dash moved this from Extended testing (optional) to Merge in Progress in Community Dashboard Dec 15, 2025
@magento-devops-reposync-svc magento-devops-reposync-svc merged commit 667cb34 into magento:2.4-develop Dec 16, 2025
10 of 12 checks passed
@ct-prd-projects-boards-automation ct-prd-projects-boards-automation bot moved this from Merge in Progress to Recently Merged in Community Dashboard Dec 16, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Priority: P3 May be fixed according to the position in the backlog. Progress: pending review Project: Community Picked PRs upvoted by the community

Projects

Status: Recently Merged

Development

Successfully merging this pull request may close these issues.

[Issue] Clarified Attribute Option already exists response

8 participants