magento/magento2#39873: addProductsToCart mutation doesn't work as expect with a given parent_sku

[KrasnoshchokBohdan]

Description (*)

First part -
In this issue, the author mentioned that responce from

this mutation

mutation {
  addProductsToCart(
    cartId: "LclKxxxxxxxxxxxxxxW"
    cartItems: [
      {
        quantity: 1
        parent_sku: "WSH12"
        sku: "WSH12-28-Green"
      }
    ]
  ) {
    cart {
      itemsV2 {
        items {
          id
          product {
            name
            sku
          }
          quantity
        }
        total_count
        page_info {
          page_size
          current_page
          total_pages
        }
      }
    }
    user_errors {
      code
      message
    }
  }
}

doesn't match

this expected result

{
  "data": {
    "addProductsToCart": {
      "cart": {
        "itemsV2": {
          "items": [
            {
              "id": "24",
              "product": {
                "name": "Erika Running Short",
                "sku": "WSH12"
              },
              "quantity": 1
            },
            {
              "id": "26",
              "product": {
                "name": "Erika Running Short-28-Green",
                "sku": "WSH12-28-Green"
              },
              "quantity": 1
            }
          ],
          "total_count": 2,
          "page_info": {
            "page_size": 20,
            "current_page": 1,
            "total_pages": 1
          }
        }
      },
      "user_errors": []
    }
  }
}

instead, we get

this actual result

{
  "data": {
    "addProductsToCart": {
      "cart": {
        "itemsV2": {
          "items": [
            {
              "id": "18",
              "product": {
                "name": "Erika Running Short-28-Green",
                "sku": "WSH12-28-Green"
              },
              "quantity": 1
            }
          ],
          "total_count": 1,
          "page_info": {
            "page_size": 20,
            "current_page": 1,
            "total_pages": 1
          }
        }
      },
      "user_errors": []
    }
  }
}

let's add a configurable product to the cart from frontend

in the "quote_item" table we have 2 items

let's try this query

and in the responce, we see only the configurable product
the reason for this is
\Magento\QuoteGraphQl\Model\Resolver\CartItemsPaginated::resolve
\Magento\Quote\Model\Quote::getAllVisibleItems

(item with sku "test simple" has parent_item_id)

so maybe it's better to change the responce example on this page instead of changing the code in \Magento\Quote\Model\Quote::getAllVisibleItems

Second part -
let's add a configurable product to the cart using the "addProductsToCart" mutation

in the responce we see only "test simple", and in "quote_item" table we have only one item

so I created ConfigurableProductPrecursor to add a configurable product to the cart along with a simple product.

Related Pull Requests

Fixed Issues (if relevant)

1. Fixes magento/magento2#39873

Manual testing scenarios (*)

1.create an empty cart the official doc
2.add a product by specifying parent_sku following the official doc

Questions or comments

Contribution checklist (*)

• Pull request has a meaningful description of its purpose
• All commits are accompanied by meaningful commit messages
• All new or changed code is covered with unit/integration tests (if applicable)
• README.md files for modified modules are updated and included in the pull request if any README.md predefined sections require an update
• All automated tests passed successfully (all builds are green)

[m2-assistant]

Hi @KrasnoshchokBohdan. Thank you for your contribution!
Here are some useful tips on how you can test your changes using Magento test environment.
❗ Automated tests can be triggered manually with an appropriate comment:

• @magento run all tests - run or re-run all required tests against the PR changes
• @magento run <test-build(s)> - run or re-run specific test build(s)
  For example: @magento run Unit Tests

<test-build(s)> is a comma-separated list of build names.

Allowed build names are:

1. Database Compare
2. Functional Tests CE
3. Functional Tests EE
4. Functional Tests B2B
5. Integration Tests
6. Magento Health Index
7. Sample Data Tests CE
8. Sample Data Tests EE
9. Sample Data Tests B2B
10. Static Tests
11. Unit Tests
12. WebAPI Tests
13. Semantic Version Checker

You can find more information about the builds here
ℹ️ Run only required test builds during development. Run all test builds before sending your pull request for review.

---

For more details, review the Code Contributions documentation.
Join Magento Community Engineering Slack and ask your questions in #github channel.

[KrasnoshchokBohdan]

@magento run all tests

[KrasnoshchokBohdan]

@magento run all tests

[KrasnoshchokBohdan]

@magento run all tests

[engcom-Hotel]

@magento run all tests

[engcom-Hotel]

Hello @KrasnoshchokBohdan,

Thanks for the collaboration!

Please look into the failed automated test, it seems they are failing due to the code changes.

Thanks

[engcom-Hotel]

User readonly here

[KrasnoshchokBohdan]

@engcom-Hotel Hi! I stuck with WebAPI tests, in report I see /var/www/html/dev/tests/api-functional/phpunit.xml
but there is no such file in the magento2 repository

and all my attempts with dev/tests/api-functional/phpunit_graphql.xml leads to errors
https://developer.adobe.com/commerce/webapi/graphql/develop/functional-testing/

[KrasnoshchokBohdan]

@magento run all tests

[KrasnoshchokBohdan]

@magento run all tests

[engcom-Hotel]

@engcom-Hotel Hi! I stuck with WebAPI tests, in report I see /var/www/html/dev/tests/api-functional/phpunit.xml
but there is no such file in the magento2 repository

Hello @KrasnoshchokBohdan,

By default, the file is named with the .dist suffix and is located at dev/tests/api-functional/. To proceed, please rename it to phpunit.xml in the same directory. For further details on running the tests, you may refer to the following documentation:

https://developer.adobe.com/commerce/webapi/get-started/web-api-functional-testing/#running-the-tests

I hope this addresses your question.

Thanks

[KrasnoshchokBohdan]

Hi! @engcom-Hotel
https://github.com/magento/magento2/tree/2.4-develop/dev/tests/api-functional

should I rename phpunit_graphql.xml.dist to phpunit.xml? Sorry, maybe I misunderstood something, but I don't see phpunit.xml.dist in the folder

[engcom-Hotel]

Hello @KrasnoshchokBohdan,

In order to run the graphql functional test on your local machine, please go through with the below documentation:

https://developer.adobe.com/commerce/webapi/graphql/develop/functional-testing/#run-functional-tests

Thanks

[engcom-Dash]

@magento run all tests

[engcom-Dash]

Hi @KrasnoshchokBohdan

Thank you for your work on this PR. While reviewing the pull request and the associated issue, I noticed that the issue is no longer reproducible. According to the documentation, the addProductsToCart mutation now returns the child product in the response.

Please find the link: https://developer.adobe.com/commerce/webapi/graphql/schema/cart/mutations/add-products/#specify-a-parent-and-a-child-sku

On 2.4-develop, as per the documentation we can see the correct behaviour.

1. Created an empty cart using graphQL mutation
2. Added configurable Product using "addProductsToCart" mutation

I understand that your PR aims to address the inconsistent behavior observed when adding a configurable product via the storefront versus through GraphQL.

However, I noticed that the changes introduced in the PR result in only parent SKUs being returned in both scenarios—storefront and GraphQL. This behavior is actually opposite to what’s documented Here. According to the documentation on the 2.4-develop branch, the addProductsToCart mutation should return the child product in the response.

Responses returned on the PR branch

Added Product to Cart Via GraphQL :

Added Product to cart via storefront:

Could you please update the PR to align with the documented behavior? Additionally, please create a new issue describing the observed behaviour and update the PR description to reference that issue.

Looking forward to your response.

Thanks!

[KrasnoshchokBohdan]

@engcom-Dash Hi!
Please check AdobeDocs/commerce-webapi#438

I made this pull request in order to either update it after approval of this pull request or to update the example response according to the current result.

I hope we can handle this pull request and I will create a new one in the documentation.

Usually pull requests for documentation can take a long time to be considered so I couldn't assume it would be merged earlier than this one, sorry

[engcom-Dash]

Hello @KrasnoshchokBohdan,

We have sent an Email to the Product Owner on the clarification of the expected behaviour for both mutation & query. Till then we are moving this PR on Hold.

Thanks!