-
Notifications
You must be signed in to change notification settings - Fork 9.4k
Fix(admin): correct datepicker position inside modal-slide #40225
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: 2.4-develop
Are you sure you want to change the base?
Fix(admin): correct datepicker position inside modal-slide #40225
Conversation
|
Hi @angelvilaplana. Thank you for your contribution!
Allowed build names are:
You can find more information about the builds here For more details, review the Code Contributions documentation. |
|
@magento run all tests |
|
@magento run Static Tests |
|
@magento run all tests |
|
Hello @angelvilaplana, Thank you for your contribution! It appears that this PR is related to the #40169 but the issue is not reproducible for us. Please refer to the this #40169 (comment). And let us know if we missed anything. Meanwhile we are moving this PR Thank you |
|
Hello @engcom-Hotel, After you mentioned that you couldn't reproduce the issue, I tested it again, and I'm still experiencing the same problem. Peek.2025-10-14.16-48.webmBecause of this, I tried using another browser, since I normally use Chrome, I tested it in Firefox to compare. After doing these tests, I can confirm that the error doesn't occur in Firefox.
I also tried using Chrome in incognito mode to check if an extension could be causing the problem, but the same bug appears there as well. I'm using Fedora, so I'm not sure if the operating system could have any influence on this issue. |

Description (*)
This pull request fixes an issue where the Magento datepicker does not display correctly inside admin modal dialogs.
For example, this affected the Advanced Pricing section when editing or creating a product from the admin panel.
To solve this problem, the
_findPosmethod of$.datepickerhas been overridden to usegetBoundingClientRect()for elements inside.modal-slide. This ensures that the datepicker is positioned correctly relative to the modal.Related Pull Requests
No related pull requests, but a related commit: 15ce386#diff-19864376467a02afb70b63ab2fe8ca2c232de016f4ae9593c61f7af293dec403
Fixed Issues (if relevant)
Manual testing scenarios (*)
Questions or comments
No additional comments.
Contribution checklist (*)