Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pwa remove gomage v1 #4404

Closed
wants to merge 2 commits into from
Closed

Pwa remove gomage v1 #4404

wants to merge 2 commits into from

Conversation

glo82145
Copy link
Collaborator

Description

TODO: Describe your changes in detail here.

Related Issue

Closes #ISSUE_NUMBER.

Acceptance

Verification Stakeholders

Specification

Verification Steps

Test scenario(s) for direct fix/feature

Test scenario(s) for any existing impacted features/areas

Test scenario(s) for any Magento Backend Supported Configurations

Is Browser/Device testing needed?

Any ad-hoc/edge case scenarios that need to be considered?

Screenshots / Screen Captures (if appropriate)

Breaking Changes (if any)

Checklist

  • I have added tests to cover my changes, if necessary.
  • I have added translations for new strings, if necessary.
  • I have updated the documentation accordingly, if necessary.

@pwa-studio-bot
Copy link
Collaborator

Fails
🚫

node failed.

Log

ERROR ON TASK: cypressTests


Error:  Danger had errors running. See message(s) above for more details.
danger-results://tmp/danger-results.json

Generated by 🚫 dangerJS against 8f17ec0

@pwa-studio-bot
Copy link
Collaborator

pwa-studio-bot commented Feb 13, 2025

Fails
🚫

node failed.

🚫

Cypress tests in the following files did not pass 😔. All tests must pass before this PR can be merged

  • contains valid CMS Page data specific to the different store:
    • CypressError: Timed out retrying after 30050ms: `cy.click()` failed because this element is not visible:

      <button data-cy="SwitcherItem-button" class="switcherItem-root-zCT flex items-center w-full">...</button>

      This element <button.switcherItem-root-zCT.flex.items-center.w-full> is not visible because its parent <li.storeSwitcher-menuItem-33L.hover_bg-subtle> has CSS property: visibility: hidden

      Fix this problem, or use {force: true} to disable error checking.

      https://on.cypress.io/element-cannot-be-interacted-with


    shows categories specific to the different store:
    • CypressError: Timed out retrying after 30050ms: cy.click() failed because this element is not visible:

      <button data-cy="SwitcherItem-button" class="switcherItem-root-zCT flex items-center w-full">...</button>

      This element <button.switcherItem-root-zCT.flex.items-center.w-full> is not visible because its parent <li.storeSwitcher-menuItem-33L.hover_bg-subtle> has CSS property: visibility: hidden

      Fix this problem, or use {force: true} to disable error checking.

      https://on.cypress.io/element-cannot-be-interacted-with


    shows products specific to the categories in the different store:
    • CypressError: Timed out retrying after 30050ms: cy.click() failed because this element is not visible:

      <button data-cy="SwitcherItem-button" class="switcherItem-root-zCT flex items-center w-full">...</button>

      This element <button.switcherItem-root-zCT.flex.items-center.w-full> is not visible because its parent <li.storeSwitcher-menuItem-33L.hover_bg-subtle> has CSS property: visibility: hidden

      Fix this problem, or use {force: true} to disable error checking.

      https://on.cypress.io/element-cannot-be-interacted-with

    ,lets users add products to cart regardless of store view:
    • AssertionError: Timed out retrying after 30000ms: Expected to find element: [data-cy="Header-root"] [data-cy="CartTrigger-counter"], but never found it.

Log

ERROR ON TASK: cypressTests


Error:  Danger had errors running. See message(s) above for more details.
danger-results://tmp/danger-results.json

Generated by 🚫 dangerJS against 8f17ec0

@pwa-studio-bot
Copy link
Collaborator

Fails
🚫 A version label is required. A maintainer must add one.
🚫

No linked issue found. Please link a relevant open issue by adding the text "closes #<issue_number>" or "closes JIRA-<issue_number>" in your PR.

🚫 Missing information in PR. Please fill out the "Description" section.
Warnings
⚠️ Found the word "TODO" in the PR description. Just letting you know incase you forgot :)
Messages
📖 DangerCI Failures related to missing labels/description/linked issues/etc will persist until the next push or next pr-test build run (assuming they are fixed).
📖

Access a deployed version of this PR here. Make sure to wait for the "pwa-pull-request-deploy" job to complete.

If your PR is missing information, check against the original template here. At a minimum you must have the section headers from the template and provide some information in each section.

Generated by 🚫 dangerJS against 8f17ec0

@glo82145
Copy link
Collaborator Author

run scaffold-pwa

@pwa-test-bot
Copy link

pwa-test-bot bot commented Feb 13, 2025

Successfully started codebuild job for scaffold-pwa

del15881
del15881 previously approved these changes Feb 13, 2025
@glo80684
Copy link
Collaborator

run scaffold-pwa

@pwa-test-bot
Copy link

pwa-test-bot bot commented Feb 13, 2025

Successfully started codebuild job for scaffold-pwa

@glo42707
Copy link
Contributor

run pr-test

@pwa-test-bot
Copy link

pwa-test-bot bot commented Feb 14, 2025

Successfully started codebuild job for pr-test

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants