Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Pwa-3431::Fixed unique id,aria-label and disabled attribute warnings #4412

Merged
merged 3 commits into from
Feb 20, 2025
Merged

Pwa-3431::Fixed unique id,aria-label and disabled attribute warnings #4412

merged 3 commits into from
Feb 20, 2025

Conversation

glo82145
Copy link
Collaborator

@glo82145 glo82145 commented Feb 20, 2025 •
edited
Loading

Description

Fixed unique id, aria-label and disabled attribute warnings in several pages of PWA

Related Issue

Closes #PWA-3409

Acceptance

Verification Stakeholders

Specification

Verification Steps

Test scenario(s) for direct fix/feature

Test scenario(s) for any existing impacted features/areas

Test scenario(s) for any Magento Backend Supported Configurations

Is Browser/Device testing needed?

Any ad-hoc/edge case scenarios that need to be considered?

Screenshots / Screen Captures (if appropriate)

Breaking Changes (if any)

Checklist

  • I have added tests to cover my changes, if necessary.
  • I have added translations for new strings, if necessary.
  • I have updated the documentation accordingly, if necessary.

@glo82145 glo82145 added the version: Patch This changeset includes backwards compatible bug fixes. label Feb 20, 2025
glo42707
glo42707 approved these changes Feb 20, 2025
View reviewed changes
Copy link
Contributor

@glo42707 glo42707 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

approved

@pwa-studio-bot
Copy link
Collaborator

Messages
📖

Associated JIRA tickets: PWA-3409.
📖 DangerCI Failures related to missing labels/description/linked issues/etc will persist until the next push or next pr-test build run (assuming they are fixed).
📖

Access a deployed version of this PR here. Make sure to wait for the "pwa-pull-request-deploy" job to complete.

Generated by 🚫 dangerJS against b8ce1c9

@glo82145 glo82145 merged commit cea6327 into release/14.2.0 Feb 20, 2025
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@glo42707 glo42707 glo42707 approved these changes

@del15881 del15881 del15881 approved these changes

Assignees

@glo42707 glo42707

@del15881 del15881

Labels
pkg:venia-ui Progress: done version: Patch This changeset includes backwards compatible bug fixes.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@glo82145 @pwa-studio-bot @glo42707 @del15881 @magento-ct-gh-projects-svc @del22123