-
Notifications
You must be signed in to change notification settings - Fork 124
Fix/mwa keep connection alive auth token restore #269
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
JoshhSandhu
wants to merge
22
commits into
magicblock-labs:main
Choose a base branch
from
JoshhSandhu:fix/mwa-keepConnectionAlive-auth-token-restore
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
22 commits
Select commit
Hold shift + click to select a range
bb5aa28
fix(mwa): clear _authToken and authToken cache on Logout
JoshhSandhu a13bd76
fix(mwa): enforce auth session restore invariant in keepConnectionAli…
JoshhSandhu eef35e6
feat(mwa): add Deauthorize() and GetCapabilities() to IAdapterOperations
JoshhSandhu 4b03eec
feat(mwa): implement Deauthorize() RPC in MobileWalletAdapterClient
JoshhSandhu e46a668
feat(mwa): implement GetCapabilities() RPC in MobileWalletAdapterClient
JoshhSandhu 74db465
feat(mwa): add DisconnectWallet(), ReconnectWallet(), and lifecycle e…
JoshhSandhu 0726e11
feat(mwa): add DisconnectWallet() and ReconnectWallet() passthroughs …
JoshhSandhu 3a9774e
fix(mwa): restore _authToken from cache at start of signing methods
JoshhSandhu 98a2234
fix(mwa): replace using var with var for LocalAssociationScenario
JoshhSandhu 6bd4acc
fix(mwa): guard reauth.AuthToken null assignment in _Login reauthoriz…
JoshhSandhu df71c17
fix(mwa): fix major lifecycle issues identified in code audit
JoshhSandhu 0b2aa3e
fix(mwa): enhance error handling in Deauthorize() and update GetCapab…
JoshhSandhu 15b0ccf
feat(mwa): added meta file for CapabilitiesResult.cs
JoshhSandhu 534c235
feat(mwa): fixed in editor error 'response' not found
JoshhSandhu 3c84d89
fix(mwa): removed deauth error handling cause of errors
JoshhSandhu 8ef67ae
Merge branch 'magicblock-labs:main' into fix/mwa-keepConnectionAlive-…
JoshhSandhu a0cefb2
fix(mwa): address CodeRabbit review comments
JoshhSandhu 05273e3
fix(mwa): address remaining CodeRabbit nitpicks
JoshhSandhu b730145
fix(mwa): address CodeRabbit critical and major review issues
JoshhSandhu e3954d2
fix(mwa): address CodeRabbit minor issues
JoshhSandhu 175ad9c
fix(mwa): address CodeRabbit nitpick and defensive null checks
JoshhSandhu ac90023
fix(mwa): guard signed result against null before dereferencing
JoshhSandhu File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
20 changes: 20 additions & 0 deletions
20
Runtime/codebase/SolanaMobileStack/JsonRpcClient/Responses/CapabilitiesResult.cs
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,20 @@ | ||
| using Newtonsoft.Json; | ||
| using UnityEngine.Scripting; | ||
|
|
||
| // ReSharper disable once CheckNamespace | ||
|
|
||
| [Preserve] | ||
| public class CapabilitiesResult | ||
| { | ||
| [JsonProperty("supports_clone_authorization")] | ||
| public bool? SupportsCloneAuthorization { get; set; } | ||
|
|
||
| [JsonProperty("max_transactions_per_request")] | ||
| public int? MaxTransactionsPerRequest { get; set; } | ||
|
|
||
| [JsonProperty("max_messages_per_request")] | ||
| public int? MaxMessagesPerRequest { get; set; } | ||
|
|
||
| [JsonProperty("supported_transaction_versions")] | ||
| public string[] SupportedTransactionVersions { get; set; } | ||
| } |
2 changes: 2 additions & 0 deletions
2
Runtime/codebase/SolanaMobileStack/JsonRpcClient/Responses/CapabilitiesResult.cs.meta
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Oops, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.