feat(WebGL): auto-select wallet when only one adapter available#275
Open
mstevens843 wants to merge 1 commit intomagicblock-labs:mainfrom
Open
feat(WebGL): auto-select wallet when only one adapter available#275mstevens843 wants to merge 1 commit intomagicblock-labs:mainfrom
mstevens843 wants to merge 1 commit intomagicblock-labs:mainfrom
Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: ASSERTIVE Plan: Pro Run ID: 📒 Files selected for processing (1)
WalkthroughThe Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~8 minutes 🚥 Pre-merge checks | ✅ 2 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (2 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
LoginWalletAdapter()shows the wallet picker UI even when only one wallet adapter is available, forcing the user to tap through a single-option selection screen.Documented as Point 1 in #273.
Solution
In
SetCurrentWallet(), afterInitWallets()populates theWalletsarray, check if exactly one wallet is present. If so, assign it directly to_currentWalletandreturn early, bypassing the picker UI entirely.
Null-safe — if
Walletsis null or empty, the existing picker flow is preserved unchanged. Multi-wallet scenarios (2+ wallets) are also unchanged.Scope: WebGL only. On Android, wallet selection is handled by the native MWA intent system. On iOS, it's hardcoded to Phantom. Neither goes through the SDK picker.
Changed file:
Runtime/codebase/SolanaWalletAdapterWebGL/SolanaWalletAdapterWebGL.csBefore & After Screenshots
BEFORE: Single-wallet picker UI shown, requiring a click to proceed.
AFTER: Wallet is auto-selected; login proceeds directly to the connection prompt.
Other changes (e.g. bug fixes, small refactors)
None. 4 lines added, 0 removed.
Deploy Notes
No new dependencies, scripts, or configuration changes.
Summary by CodeRabbit