Skip to content

Fix missing DelayQueue key tracking in register_task #1116

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
S0nee wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Fix missing DelayQueue key tracking in register_task #1116

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 7 additions & 5 deletions magicblock-task-scheduler/src/service.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -221,9 +221,7 @@ impl TaskSchedulerService {
return Ok(());
}

self.remove_task_from_queue(cancel_request.task_id);

// Remove task from database
// Remove task from queue and database
self.unregister_task(cancel_request.task_id).await?;

Ok(())
Expand Down Expand Up @@ -278,17 +276,21 @@ impl TaskSchedulerService {
}

self.db.insert_task(&task).await?;
self.task_queue
self.remove_task_from_queue(task.id);
let key = self
.task_queue
.insert(task.clone(), Duration::from_millis(0));
self.task_queue_keys.insert(task.id, key);
debug!("Registered task {} from context", task.id);

Ok(())
}

pub async fn unregister_task(
&self,
&mut self,
task_id: i64,
) -> TaskSchedulerResult<()> {
self.remove_task_from_queue(task_id);
self.db.remove_task(task_id).await?;
debug!("Removed task {} from database", task_id);

Expand Down