Skip to content

Propagate cleanup boundary error in get_block #1121

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
nikolaysamoil0ff wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Propagate cleanup boundary error in get_block #1121

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
2ab337d
Propagate cleanup boundary error in get_block
nikolaysamoil0ff Mar 31, 2026
c9fc633
Update api.rs
nikolaysamoil0ff Mar 31, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 10 additions & 2 deletions magicblock-ledger/src/store/api.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -396,7 +396,7 @@ impl Ledger {
let previous_blockhash = self.get_block_hash(previous_slot)?;

let transactions = {
let _lock = self.check_lowest_cleanup_slot(slot);
let _lock = self.check_lowest_cleanup_slot(slot)?;
let index_iterator = self
.slot_signatures_cf
.iter_current_index_filtered(IteratorMode::From(
Expand All @@ -422,9 +422,17 @@ impl Ledger {
.transaction_status_cf
.get_protobuf((tx_signature, slot))?
.ok_or(LedgerError::TransactionStatusMetaNotFound)?;
let meta = TransactionStatusMeta::try_from(meta).map_err(
|e| {
LedgerError::TransactionConversionError(format!(
"failed to convert transaction status meta at slot {}: {}",
slot, e
))
},
)?;
Ok(VersionedTransactionWithStatusMeta {
transaction,
meta: TransactionStatusMeta::try_from(meta).unwrap(),
meta,
})
})
.collect::<LedgerResult<Vec<_>>>()
Expand Down