New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[WIP] Detect functions declared in the same file #193

Open

vudaltsov wants to merge 2 commits into maglnet:master from vudaltsov:functions-in-the-same-file

vudaltsov commented Jul 11, 2020

Fixes #179

make test fail
fix the issue

vudaltsov added 2 commits

July 11, 2020 18:01


          Made LocateUsedSymbolsFromASTRootsTest fail

d8634d6


          Corrected expectations in LocateUsedSymbolsFromASTRootsTest

fa34433

Author

vudaltsov commented Jul 11, 2020

I think, I found the problem.

https://github.com/nikic/PHP-Parser/blob/master/doc/component/Name_resolution.markdown

Unqualified function and constant names inside a namespace cannot be statically resolved. Inside a namespace Foo, a call to strlen() may either refer to the namespaced \Foo\strlen(), or the global \strlen(). Because PHP-Parser does not have the necessary context to decide this, such names are left unresolved. Additionally a namespacedName attribute is added to the name node.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet