Stabilize setup #73
Open
Stabilize setup #73
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…it is formatted properly already
…e 'css' service can use Rails commands
…with the rest of the docker stack
… botselect Stimulus controller
codenamev
commented
Aug 28, 2023
| @@ -9,7 +9,7 @@ def create | |||
|
|
|||
| # todo: should we do this everytime? | |||
| calendar = service.get_calendar('primary') | |||
| user.update!(time_zone: calendar.time_zone.split('/').last.gsub('_', ' ')) | |||
| user.update!(time_zone: calendar.time_zone) | |||
There was a problem hiding this comment.
When I signed up, my time zone was pulling from Google's APIs in the railsy formatAmerica/New_York. Setting it with the spaces as it is throws an error downstream when trying to use_zone
codenamev
commented
Aug 28, 2023
| @@ -116,10 +116,6 @@ def summary | |||
| analysis[:summary] | |||
| end | |||
|
|
|||
| def tags | |||
There was a problem hiding this comment.
I think this was maybe missed in conflict resolution, but there's a duplicate method that handles an edge case better.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This consolidates a series of issues I ran into getting things setup and running locally. I'd be happy to break any of this up into any separate PRs if you desire; or drop any commits you're not interested in.